public inbox for glibc-bugs@sourceware.org
help / color / mirror / Atom feed
* [Bug build/30545] New: "make tests-clean" is not reliable
@ 2023-06-12 15:30 maxim.kuvyrkov at gmail dot com
2023-06-13 12:11 ` [Bug build/30545] " carlos at redhat dot com
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: maxim.kuvyrkov at gmail dot com @ 2023-06-12 15:30 UTC (permalink / raw)
To: glibc-bugs
https://sourceware.org/bugzilla/show_bug.cgi?id=30545
Bug ID: 30545
Summary: "make tests-clean" is not reliable
Product: glibc
Version: unspecified
Status: UNCONFIRMED
Severity: minor
Priority: P2
Component: build
Assignee: unassigned at sourceware dot org
Reporter: maxim.kuvyrkov at gmail dot com
CC: carlos at redhat dot com
Target Milestone: ---
$ ../glibc/configure --prefix=/usr
$ make -j160
$ find -name "*.out" -o -name "*.test-result" | wc -l
0
$ make -j160 check
$ find -name "*.out" -o -name "*.test-result" | wc -l
9210
$ make tests-clean
$ find -name "*.out" -o -name "*.test-result" | wc -l
3297
"tests-clean" relies on do-tests-clean to clean individual subdirs, which, in
turn, relies for subdirs to provide exhaustive list of all tests:
===
do-tests-clean:
-rm -f $(addprefix $(objpfx),$(addsuffix .out,$(tests) \
$(tests-internal) \
$(xtests) \
$(test-srcs)) \
$(addsuffix .test-result,$(tests) \
$(tests-internal)
\
$(xtests) \
$(test-srcs)))
===
I suggest changing the above to:
===
do-tests-clean:
-find $(objpfx) -name "*.out" -delete
-find $(objpfx) -name "*.test-result" -delete
===
... or something similar.
Another alternative is to remove the "tests-clean" target, since most
developers don't trust it now.
--
You are receiving this mail because:
You are on the CC list for the bug.
^ permalink raw reply [flat|nested] 4+ messages in thread
* [Bug build/30545] "make tests-clean" is not reliable
2023-06-12 15:30 [Bug build/30545] New: "make tests-clean" is not reliable maxim.kuvyrkov at gmail dot com
@ 2023-06-13 12:11 ` carlos at redhat dot com
2023-06-15 15:28 ` maxim.kuvyrkov at gmail dot com
2023-06-15 15:33 ` sam at gentoo dot org
2 siblings, 0 replies; 4+ messages in thread
From: carlos at redhat dot com @ 2023-06-13 12:11 UTC (permalink / raw)
To: glibc-bugs
https://sourceware.org/bugzilla/show_bug.cgi?id=30545
Carlos O'Donell <carlos at redhat dot com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Last reconfirmed| |2023-06-13
Status|UNCONFIRMED |NEW
Ever confirmed|0 |1
--- Comment #1 from Carlos O'Donell <carlos at redhat dot com> ---
(In reply to Maxim Kuvyrkov from comment #0)
> I suggest changing the above to:
> ===
> do-tests-clean:
> -find $(objpfx) -name "*.out" -delete
> -find $(objpfx) -name "*.test-result" -delete
> ===
> ... or something similar.
Agreed, this is a better solution than the recursive one.
Please propose this change as a patch and I'll happily review.
Then I'll go over the test-container tests with DJ to add a stage that deletes
the container chroot so it gets recreated.
--
You are receiving this mail because:
You are on the CC list for the bug.
^ permalink raw reply [flat|nested] 4+ messages in thread
* [Bug build/30545] "make tests-clean" is not reliable
2023-06-12 15:30 [Bug build/30545] New: "make tests-clean" is not reliable maxim.kuvyrkov at gmail dot com
2023-06-13 12:11 ` [Bug build/30545] " carlos at redhat dot com
@ 2023-06-15 15:28 ` maxim.kuvyrkov at gmail dot com
2023-06-15 15:33 ` sam at gentoo dot org
2 siblings, 0 replies; 4+ messages in thread
From: maxim.kuvyrkov at gmail dot com @ 2023-06-15 15:28 UTC (permalink / raw)
To: glibc-bugs
https://sourceware.org/bugzilla/show_bug.cgi?id=30545
--- Comment #2 from Maxim Kuvyrkov <maxim.kuvyrkov at gmail dot com> ---
Patch posted
https://patchwork.sourceware.org/project/glibc/patch/20230615152547.2924770-1-maxim.kuvyrkov@linaro.org/
--
You are receiving this mail because:
You are on the CC list for the bug.
^ permalink raw reply [flat|nested] 4+ messages in thread
* [Bug build/30545] "make tests-clean" is not reliable
2023-06-12 15:30 [Bug build/30545] New: "make tests-clean" is not reliable maxim.kuvyrkov at gmail dot com
2023-06-13 12:11 ` [Bug build/30545] " carlos at redhat dot com
2023-06-15 15:28 ` maxim.kuvyrkov at gmail dot com
@ 2023-06-15 15:33 ` sam at gentoo dot org
2 siblings, 0 replies; 4+ messages in thread
From: sam at gentoo dot org @ 2023-06-15 15:33 UTC (permalink / raw)
To: glibc-bugs
https://sourceware.org/bugzilla/show_bug.cgi?id=30545
Sam James <sam at gentoo dot org> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |sam at gentoo dot org
--
You are receiving this mail because:
You are on the CC list for the bug.
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2023-06-15 15:33 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-06-12 15:30 [Bug build/30545] New: "make tests-clean" is not reliable maxim.kuvyrkov at gmail dot com
2023-06-13 12:11 ` [Bug build/30545] " carlos at redhat dot com
2023-06-15 15:28 ` maxim.kuvyrkov at gmail dot com
2023-06-15 15:33 ` sam at gentoo dot org
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).