From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <sourceware-bugzilla@sourceware.org>
Received: by sourceware.org (Postfix, from userid 48)
	id D9A103858D38; Mon, 12 Jun 2023 15:30:34 +0000 (GMT)
DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org D9A103858D38
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org;
	s=default; t=1686583834;
	bh=P3s4KxiggapeUST9hnfUjUFv8Qr6/6MX3wnSdVpPsxo=;
	h=From:To:Subject:Date:From;
	b=fov5wvrMFZPMa554D6zZ7XgmNC9PEWJhNzbDZePoI23JaICzpqygp7wLiJjoLNfqT
	 2pfX4SExULjTJyBadNCs94psUOvxNvw6lGzdBl2nlc5qgTwOnPuqu3H+jgqxfMq02d
	 jlPJs0psKjKaT2ZNn7EO4FHpUr3BLNoU0HisNZsk=
From: "maxim.kuvyrkov at gmail dot com" <sourceware-bugzilla@sourceware.org>
To: glibc-bugs@sourceware.org
Subject: [Bug build/30545] New: "make tests-clean" is not reliable
Date: Mon, 12 Jun 2023 15:30:34 +0000
X-Bugzilla-Reason: CC
X-Bugzilla-Type: new
X-Bugzilla-Watch-Reason: None
X-Bugzilla-Product: glibc
X-Bugzilla-Component: build
X-Bugzilla-Version: unspecified
X-Bugzilla-Keywords: 
X-Bugzilla-Severity: minor
X-Bugzilla-Who: maxim.kuvyrkov at gmail dot com
X-Bugzilla-Status: UNCONFIRMED
X-Bugzilla-Resolution: 
X-Bugzilla-Priority: P2
X-Bugzilla-Assigned-To: unassigned at sourceware dot org
X-Bugzilla-Target-Milestone: ---
X-Bugzilla-Flags: 
X-Bugzilla-Changed-Fields: bug_id short_desc product version bug_status
 bug_severity priority component assigned_to reporter cc target_milestone
Message-ID: <bug-30545-131@http.sourceware.org/bugzilla/>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
X-Bugzilla-URL: http://sourceware.org/bugzilla/
Auto-Submitted: auto-generated
MIME-Version: 1.0
List-Id: <glibc-bugs.sourceware.org>

https://sourceware.org/bugzilla/show_bug.cgi?id=3D30545

            Bug ID: 30545
           Summary: "make tests-clean" is not reliable
           Product: glibc
           Version: unspecified
            Status: UNCONFIRMED
          Severity: minor
          Priority: P2
         Component: build
          Assignee: unassigned at sourceware dot org
          Reporter: maxim.kuvyrkov at gmail dot com
                CC: carlos at redhat dot com
  Target Milestone: ---

$ ../glibc/configure --prefix=3D/usr
$ make -j160
$ find -name "*.out" -o -name "*.test-result" | wc -l
0
$ make -j160 check
$ find -name "*.out" -o -name "*.test-result" | wc -l
9210
$ make tests-clean
$ find -name "*.out" -o -name "*.test-result" | wc -l
3297

"tests-clean" relies on do-tests-clean to clean individual subdirs, which, =
in
turn, relies for subdirs to provide exhaustive list of all tests:
=3D=3D=3D
do-tests-clean:
        -rm -f $(addprefix $(objpfx),$(addsuffix .out,$(tests) \
                                                      $(tests-internal) \
                                                      $(xtests) \
                                                      $(test-srcs)) \
                                     $(addsuffix .test-result,$(tests) \
                                                              $(tests-inter=
nal)
\
                                                              $(xtests) \
                                                              $(test-srcs)))
=3D=3D=3D

I suggest changing the above to:
=3D=3D=3D
do-tests-clean:
        -find $(objpfx) -name "*.out" -delete
        -find $(objpfx) -name "*.test-result" -delete
=3D=3D=3D
... or something similar.

Another alternative is to remove the "tests-clean" target, since most
developers don't trust it now.

--=20
You are receiving this mail because:
You are on the CC list for the bug.=