public inbox for glibc-bugs@sourceware.org
help / color / mirror / Atom feed
From: "adhemerval.zanella at linaro dot org" <sourceware-bugzilla@sourceware.org>
To: glibc-bugs@sourceware.org
Subject: [Bug libc/30558] SIGEV_THREAD is badly implemented
Date: Mon, 19 Jun 2023 21:15:29 +0000	[thread overview]
Message-ID: <bug-30558-131-bnBDA2Vk5u@http.sourceware.org/bugzilla/> (raw)
In-Reply-To: <bug-30558-131@http.sourceware.org/bugzilla/>

https://sourceware.org/bugzilla/show_bug.cgi?id=30558

--- Comment #13 from Adhemerval Zanella <adhemerval.zanella at linaro dot org> ---
(In reply to Stas Sergeev from comment #12)
> > And since it is the kernel that keep track of the overrun, the reentrancy
> > issue is not really related on the overrun itself, but rather on the sigval
> > argument.
> 
> Overruns are measured between signal queue
> and dequeue. Linux fixes that scheme by
> actually measuring between 2 subsequent
> dequeues AFAIKS, though doesn't matter.
> What matters is that, because of reentrancy,
> the handler will query the overruns after
> another signal was already delivered, so
> the result would be a complete garbage.

Ok, I now see what you mean here. Indeed afaik Linux reset the overrun time on
each sigtimedwait syscall.  

> 
> > My understanding from the quote you borght is not that it is specified
> > that concurrent threads are allowed or not
> 
> Let me quote again then:
> [quote]
> the threads created in response to a timer expiration are created detached,
> or in an unspecified way if the thread attribute's detachstate is
> PTHREAD_CREATE_JOINABLE.
> [/quote]
> 
> Three things are being said here:
> 1. Threads are created in a response to every timer expiration

Reading the SIGEV_THREAD description [1], it is not clear to me that a new
thread should be created for *every* timer expiration from the same timer. In
fact, POSIX also advises against it on the timer_settime application because of
the concurrent stack usage issue [2].  So, the current scheme has the
additional drawback that a user-specific stack is really not safe.

> 2. They are detached
> 3. The user can specify PTHREAD_CREATE_JOINABLE, in which
> case the behavior is implementation-specific.
> 
> I propose to use 3 as a base for implementing
> PTHREAD_CREATE_JOINABLE case first, then see
> what remains.

But POSIX explicitly states that the thread is *not* joinable ("In neither case
is it valid to call pthread_join()"), and as I said it makes even tricker to
handle the per-timer thread (what happens to the timer after the thread is
joined? Should pthread_join issue timer_delete? What happens if there thread if
cancelled or issue pthread_exit?).

[1] https://pubs.opengroup.org/onlinepubs/9699919799/functions/V2_chap02.html
[2]
https://pubs.opengroup.org/onlinepubs/9699919799/functions/timer_settime.html

-- 
You are receiving this mail because:
You are on the CC list for the bug.

  parent reply	other threads:[~2023-06-19 21:15 UTC|newest]

Thread overview: 32+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-06-15 19:36 [Bug libc/30558] New: " stsp at users dot sourceforge.net
2023-06-15 21:04 ` [Bug libc/30558] " adhemerval.zanella at linaro dot org
2023-06-16  2:23 ` stsp at users dot sourceforge.net
2023-06-16  6:44 ` stsp at users dot sourceforge.net
2023-06-16  7:29 ` stsp at users dot sourceforge.net
2023-06-16  7:51 ` stsp at users dot sourceforge.net
2023-06-16 11:44 ` stsp at users dot sourceforge.net
2023-06-19 17:41 ` adhemerval.zanella at linaro dot org
2023-06-19 18:54 ` stsp at users dot sourceforge.net
2023-06-19 19:33 ` adhemerval.zanella at linaro dot org
2023-06-19 19:48 ` stsp at users dot sourceforge.net
2023-06-19 20:14 ` adhemerval.zanella at linaro dot org
2023-06-19 20:26 ` stsp at users dot sourceforge.net
2023-06-19 21:15 ` adhemerval.zanella at linaro dot org [this message]
2023-06-19 21:21 ` adhemerval.zanella at linaro dot org
2023-06-19 21:58 ` stsp at users dot sourceforge.net
2023-06-19 22:51 ` adhemerval.zanella at linaro dot org
2023-06-20  4:14 ` stsp at users dot sourceforge.net
2023-06-20 12:21 ` adhemerval.zanella at linaro dot org
2023-06-20 12:49 ` stsp at users dot sourceforge.net
2023-06-20 13:01 ` adhemerval.zanella at linaro dot org
2023-06-20 13:13 ` stsp at users dot sourceforge.net
2023-06-21  3:19 ` stsp at users dot sourceforge.net
2023-06-21 14:32 ` adhemerval.zanella at linaro dot org
2023-06-21 14:41 ` stsp at users dot sourceforge.net
2023-06-21 14:43 ` adhemerval.zanella at linaro dot org
2023-06-21 14:52 ` stsp at users dot sourceforge.net
2023-06-21 15:07 ` adhemerval.zanella at linaro dot org
2023-06-22  2:57 ` bugdal at aerifal dot cx
2023-06-22  5:23 ` stsp at users dot sourceforge.net
2023-06-23 18:34 ` adhemerval.zanella at linaro dot org
2023-06-24 17:03 ` crrodriguez at opensuse dot org

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bug-30558-131-bnBDA2Vk5u@http.sourceware.org/bugzilla/ \
    --to=sourceware-bugzilla@sourceware.org \
    --cc=glibc-bugs@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).