public inbox for glibc-bugs@sourceware.org
help / color / mirror / Atom feed
From: "dave.anglin at bell dot net" <sourceware-bugzilla@sourceware.org>
To: glibc-bugs@sourceware.org
Subject: [Bug nptl/30587] FAIL: nptl/tst-cleanupx4 on hppa
Date: Tue, 27 Jun 2023 20:26:50 +0000	[thread overview]
Message-ID: <bug-30587-131-kQfoMw7S5R@http.sourceware.org/bugzilla/> (raw)
In-Reply-To: <bug-30587-131@http.sourceware.org/bugzilla/>

https://sourceware.org/bugzilla/show_bug.cgi?id=30587

--- Comment #8 from dave.anglin at bell dot net ---
On 2023-06-27 12:02 p.m., fberat at redhat dot com wrote:
> https://sourceware.org/bugzilla/show_bug.cgi?id=30587
>
> --- Comment #4 from Frédéric Bérat <fberat at redhat dot com> ---
> Since I don't have the access yet, I'm looking at the logs:
>
> test 0
> clh (2)
> global = 2, expected 15
>
> This executes fn2(), which should basically do:
>    pthread_cleanup_push (clh, (void *) 3l);
>    _pthread_cleanup_push (&b, clh, (void *) 2l);
>    pthread_cleanup_push (clh, (void *) 1l);
>
> Whereas, from the output, only `_pthread_cleanup_pop (&b, 1);` seems to be
> executed.
>
> The same goes for the following iterations. It looks like only
> _pthread_cleanup_pop actions get executed on cancellation.
>
> I don't see how this could be induced by the aforementioned patch.
It seems to me that the sequencing of the cleanups must be timing dependent. 
Simply changing
the read in tst-cleanup4.c to xread changes the test result from PASS to FAIL.

The test doesn't fail if xread is moved into tst-cleanup4.c.

-- 
You are receiving this mail because:
You are on the CC list for the bug.

  parent reply	other threads:[~2023-06-27 20:26 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-06-26 17:11 [Bug nptl/30587] New: " danglin at gcc dot gnu.org
2023-06-26 17:42 ` [Bug nptl/30587] " sam at gentoo dot org
2023-06-27 14:08 ` fberat at redhat dot com
2023-06-27 14:52 ` dave.anglin at bell dot net
2023-06-27 14:58 ` dave.anglin at bell dot net
2023-06-27 16:02 ` fberat at redhat dot com
2023-06-27 16:45 ` adhemerval.zanella at linaro dot org
2023-06-27 17:13 ` sam at gentoo dot org
2023-06-27 19:09 ` deller at gmx dot de
2023-06-27 20:26 ` dave.anglin at bell dot net [this message]
2023-06-28 14:39 ` dave.anglin at bell dot net
2023-06-28 14:56 ` carlos at redhat dot com
2023-07-01 13:33 ` danglin at gcc dot gnu.org

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bug-30587-131-kQfoMw7S5R@http.sourceware.org/bugzilla/ \
    --to=sourceware-bugzilla@sourceware.org \
    --cc=glibc-bugs@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).