public inbox for glibc-bugs@sourceware.org
help / color / mirror / Atom feed
From: "kashiwagi at unimplemented dot net" <sourceware-bugzilla@sourceware.org>
To: glibc-bugs@sourceware.org
Subject: [Bug locale/30666] New: Malfunction caused by duplicate conditional statements in "locale/programs/charmap.c"
Date: Sun, 23 Jul 2023 16:14:50 +0000	[thread overview]
Message-ID: <bug-30666-131@http.sourceware.org/bugzilla/> (raw)

https://sourceware.org/bugzilla/show_bug.cgi?id=30666

            Bug ID: 30666
           Summary: Malfunction caused by duplicate conditional statements
                    in "locale/programs/charmap.c"
           Product: glibc
           Version: unspecified
            Status: UNCONFIRMED
          Severity: minor
          Priority: P2
         Component: locale
          Assignee: unassigned at sourceware dot org
          Reporter: kashiwagi at unimplemented dot net
  Target Milestone: ---

Created attachment 14998
  --> https://sourceware.org/bugzilla/attachment.cgi?id=14998&action=edit
bugfix

There is a bug in the "locale/programs/charmap.c" file. The problem lies within
the following code:

if ((nowtok == tok_mb_cur_max
     && result->mb_cur_max != 0)
     || (nowtok == tok_mb_cur_max
     && result->mb_cur_max != 0))

Suggested Fix:
The conditional statement should be corrected as follows:

if ((nowtok == tok_mb_cur_max
     && result->mb_cur_max != 0)
     || (nowtok == tok_mb_cur_min
     && result->mb_cur_min != 0))

It seems that there was a duplication of the same condition, and one of the
conditions should be comparing with tok_mb_cur_min instead of tok_mb_cur_max.
This change should address the issue and ensure proper functionality.

-- 
You are receiving this mail because:
You are on the CC list for the bug.

                 reply	other threads:[~2023-07-23 16:14 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bug-30666-131@http.sourceware.org/bugzilla/ \
    --to=sourceware-bugzilla@sourceware.org \
    --cc=glibc-bugs@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).