public inbox for glibc-bugs@sourceware.org
help / color / mirror / Atom feed
From: "adhemerval.zanella at linaro dot org" <sourceware-bugzilla@sourceware.org>
To: glibc-bugs@sourceware.org
Subject: [Bug libc/30737] fdopendir() is not robust - returns bogus DIR* instead of flagging an error
Date: Thu, 10 Aug 2023 11:04:59 +0000 [thread overview]
Message-ID: <bug-30737-131-KkB9t91XYE@http.sourceware.org/bugzilla/> (raw)
In-Reply-To: <bug-30737-131@http.sourceware.org/bugzilla/>
https://sourceware.org/bugzilla/show_bug.cgi?id=30737
--- Comment #5 from Adhemerval Zanella <adhemerval.zanella at linaro dot org> ---
(In reply to Mark Galeck from comment #4)
> Right, I did not mean to say readdir() did not report error; I did not check
> the error return of readdir().
>
> Yes so the only question is that of early failure versus later failure.
>
> Up to you, fine with me if you close it.
I think it is a QoI to fail early, and it is a free check on fdopendir. I will
send a patch.
--
You are receiving this mail because:
You are on the CC list for the bug.
next prev parent reply other threads:[~2023-08-10 11:05 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-08 15:52 [Bug libc/30737] New: " markgaleck at gmail dot com
2023-08-08 16:26 ` [Bug libc/30737] " markgaleck at gmail dot com
2023-08-08 16:27 ` markgaleck at gmail dot com
2023-08-08 20:48 ` adhemerval.zanella at linaro dot org
2023-08-08 23:35 ` markgaleck at gmail dot com
2023-08-10 11:04 ` adhemerval.zanella at linaro dot org [this message]
2023-11-30 16:38 ` adhemerval.zanella at linaro dot org
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bug-30737-131-KkB9t91XYE@http.sourceware.org/bugzilla/ \
--to=sourceware-bugzilla@sourceware.org \
--cc=glibc-bugs@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).