[Bug build/30740] [m68k] undefined reference to `_wordcopy_fwd_dest_aligned'

["adhemerval.zanella at linaro dot org" <sourceware-bugzilla@sourceware.org>]

https://sourceware.org/bugzilla/show_bug.cgi?id=30740

Adhemerval Zanella <adhemerval.zanella at linaro dot org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |adhemerval.zanella at linaro dot o
                   |                            |rg

--- Comment #1 from Adhemerval Zanella <adhemerval.zanella at linaro dot org> ---
The issue is that we only test for m68020, which should use the optimized
macros from sysdeps/m68k/memcopy.h and not use the wordcopy.c routines. To fix
it should be as simple as:

diff --git a/sysdeps/m68k/m680x0/m68020/wordcopy.S
b/sysdeps/m68k/m680x0/m68020/wordcopy.S
deleted file mode 100644
index 4fb1a4518f..0000000000
--- a/sysdeps/m68k/m680x0/m68020/wordcopy.S
+++ /dev/null
@@ -1 +0,0 @@
-/* Empty, not needed.  */
diff --git a/sysdeps/m68k/wordcopy.c b/sysdeps/m68k/wordcopy.c
new file mode 100644
index 0000000000..e459e0e403
--- /dev/null
+++ b/sysdeps/m68k/wordcopy.c
@@ -0,0 +1,21 @@
+/* Definitions for memory copy functions.  Motorola 68020 version.
+   Copyright (C) 2023 Free Software Foundation, Inc.
+   This file is part of the GNU C Library.
+
+   The GNU C Library is free software; you can redistribute it and/or
+   modify it under the terms of the GNU Lesser General Public
+   License as published by the Free Software Foundation; either
+   version 2.1 of the License, or (at your option) any later version.
+
+   The GNU C Library is distributed in the hope that it will be useful,
+   but WITHOUT ANY WARRANTY; without even the implied warranty of
+   MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
+   Lesser General Public License for more details.
+
+   You should have received a copy of the GNU Lesser General Public
+   License along with the GNU C Library.  If not, see
+   <https://www.gnu.org/licenses/>.  */
+
+#if !defined(__mc68020__) && !defined(mc68020)
+#include <string/wordcopy.c>
+#endif

However, since we do not actually build everything for anything different than
m68020; the math code assumes m68020 FLT_EVAL_METHOD (which is 2 since it uses
the external 68881 math processor).  And this is not correct fro m68040 which
now has a builtin FP processor and thus GCC uses a different  FLT_EVAL_METHOD
(0).

The FP issues should be simple to fix by removing
sysdeps/m68k/m680x0/bits/flt-eval-method.h and letting using the generic one,
but I don't have a way to actually test it.

-- 
You are receiving this mail because:
You are on the CC list for the bug.