From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: by sourceware.org (Postfix, from userid 48) id 8713B3857702; Thu, 10 Aug 2023 13:23:51 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 8713B3857702 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1691673831; bh=FrSReJJSexJeLVxURsSlCszHv/LElbJqWg+t2/jzPlY=; h=From:To:Subject:Date:In-Reply-To:References:From; b=qZoIpgIq2kiVpq1ijCp8mZMa0uwOv2wHciv89s4bAcwGrk14S7jf8ESOmLr0R0ZMT l/cmqZ3c+1MncXCovk1pIuOOXymfCnRRG+/SCpWqs7B6mqv+W9hSaMXWdEltZQF1qY A525HIIodBrlQyJcgue3wODOwCSv4yWJJXECbilc= From: "adhemerval.zanella at linaro dot org" To: glibc-bugs@sourceware.org Subject: [Bug build/30740] [m68k] undefined reference to `_wordcopy_fwd_dest_aligned' Date: Thu, 10 Aug 2023 13:23:50 +0000 X-Bugzilla-Reason: CC X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: glibc X-Bugzilla-Component: build X-Bugzilla-Version: 2.38 X-Bugzilla-Keywords: X-Bugzilla-Severity: normal X-Bugzilla-Who: adhemerval.zanella at linaro dot org X-Bugzilla-Status: UNCONFIRMED X-Bugzilla-Resolution: X-Bugzilla-Priority: P2 X-Bugzilla-Assigned-To: unassigned at sourceware dot org X-Bugzilla-Target-Milestone: --- X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: cc Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: http://sourceware.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 List-Id: https://sourceware.org/bugzilla/show_bug.cgi?id=3D30740 Adhemerval Zanella changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |adhemerval.zanella at lina= ro dot o | |rg --- Comment #1 from Adhemerval Zanella --- The issue is that we only test for m68020, which should use the optimized macros from sysdeps/m68k/memcopy.h and not use the wordcopy.c routines. To = fix it should be as simple as: diff --git a/sysdeps/m68k/m680x0/m68020/wordcopy.S b/sysdeps/m68k/m680x0/m68020/wordcopy.S deleted file mode 100644 index 4fb1a4518f..0000000000 --- a/sysdeps/m68k/m680x0/m68020/wordcopy.S +++ /dev/null @@ -1 +0,0 @@ -/* Empty, not needed. */ diff --git a/sysdeps/m68k/wordcopy.c b/sysdeps/m68k/wordcopy.c new file mode 100644 index 0000000000..e459e0e403 --- /dev/null +++ b/sysdeps/m68k/wordcopy.c @@ -0,0 +1,21 @@ +/* Definitions for memory copy functions. Motorola 68020 version. + Copyright (C) 2023 Free Software Foundation, Inc. + This file is part of the GNU C Library. + + The GNU C Library is free software; you can redistribute it and/or + modify it under the terms of the GNU Lesser General Public + License as published by the Free Software Foundation; either + version 2.1 of the License, or (at your option) any later version. + + The GNU C Library is distributed in the hope that it will be useful, + but WITHOUT ANY WARRANTY; without even the implied warranty of + MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU + Lesser General Public License for more details. + + You should have received a copy of the GNU Lesser General Public + License along with the GNU C Library. If not, see + . */ + +#if !defined(__mc68020__) && !defined(mc68020) +#include +#endif However, since we do not actually build everything for anything different t= han m68020; the math code assumes m68020 FLT_EVAL_METHOD (which is 2 since it u= ses the external 68881 math processor). And this is not correct fro m68040 whi= ch now has a builtin FP processor and thus GCC uses a different FLT_EVAL_METH= OD (0). The FP issues should be simple to fix by removing sysdeps/m68k/m680x0/bits/flt-eval-method.h and letting using the generic on= e, but I don't have a way to actually test it. --=20 You are receiving this mail because: You are on the CC list for the bug.=