[Bug libc/31068] sysdeps: sparc: invalid data access in memset due to regression

["adhemerval.zanella at linaro dot org" <sourceware-bugzilla@sourceware.org>]

https://sourceware.org/bugzilla/show_bug.cgi?id=31068

--- Comment #4 from Adhemerval Zanella <adhemerval.zanella at linaro dot org> ---
(In reply to John Paul Adrian Glaubitz from comment #3)
> (In reply to Adhemerval Zanella from comment #1)
> > Fixed on 2.39.
> 
> Does this by any chance need to be fixed on sparc64 as well?
> 
> This bug could be the reason for the posix_spawn() bug we're seeing on
> sparc64.

The sparc64 changes were less intrusive and I could not see any change that
might trigger it.  The niagara4 changes slight the alignment of the 'clr'
instruction:

diff --git a/sysdeps/sparc/sparc64/multiarch/memset-niagara4.S
b/sysdeps/sparc/sparc64/multiarch/memset-niagara4.S
index 1ccf24e516..d6fbd83009 100644
--- a/sysdeps/sparc/sparc64/multiarch/memset-niagara4.S
+++ b/sysdeps/sparc/sparc64/multiarch/memset-niagara4.S
@@ -39,10 +39,6 @@ ENTRY(__memset_niagara4)
        sllx            %o2, 32, %g1
        ba,pt           %icc, 1f
         or             %g1, %o2, %o4
-END(__memset_niagara4)
-
-       .align          32
-ENTRY(__bzero_niagara4)
        clr             %o4
 1:     cmp             %o1, 16
        ble             %icc, .Ltiny
@@ -118,6 +114,6 @@ ENTRY(__bzero_niagara4)
        bne,pt          %icc, 1b
         add            %o0, 0x30, %o0
        ba,a,pt         %icc, .Lpostloop
-END(__bzero_niagara4)
+END(__memset_niagara4)

 #endif

But afaiu this should not change the correctness of the code. 

Also, unless you are building with --disable-multi-arch; sparc64 string tests
will check for every string implementation currently supported by the CPU. So I
would expect that a failure in memset would trigger at least one regression as
for sparc32.

-- 
You are receiving this mail because:
You are on the CC list for the bug.