public inbox for glibc-bugs@sourceware.org
help / color / mirror / Atom feed
From: "cvs-commit at gcc dot gnu.org" <sourceware-bugzilla@sourceware.org>
To: glibc-bugs@sourceware.org
Subject: [Bug dynamic-link/31187] Some CET tests fail with GCC 14
Date: Mon, 01 Jan 2024 23:56:42 +0000	[thread overview]
Message-ID: <bug-31187-131-KtGlM9AUYR@http.sourceware.org/bugzilla/> (raw)
In-Reply-To: <bug-31187-131@http.sourceware.org/bugzilla/>

https://sourceware.org/bugzilla/show_bug.cgi?id=31187

--- Comment #1 from Sourceware Commits <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by H.J. Lu <hjl@sourceware.org>:

https://sourceware.org/git/gitweb.cgi?p=glibc.git;h=b5dcccfb12385ee492eb074f6beb9ead56b5e5fd

commit b5dcccfb12385ee492eb074f6beb9ead56b5e5fd
Author: H.J. Lu <hjl.tools@gmail.com>
Date:   Mon Jan 1 07:55:18 2024 -0800

    x86/cet: Add -fcf-protection=none before -fcf-protection=branch

    When shadow stack is enabled, some CET tests failed when compiled with
    GCC 14:

    FAIL: elf/tst-cet-legacy-4
    FAIL: elf/tst-cet-legacy-5a
    FAIL: elf/tst-cet-legacy-6a

    which are caused by

    https://gcc.gnu.org/bugzilla/show_bug.cgi?id=113039

    These tests use -fcf-protection -fcf-protection=branch and assume that
    -fcf-protection=branch will override -fcf-protection.  But this GCC 14
    commit:

    https://gcc.gnu.org/git/gitweb.cgi?p=gcc.git;h=1c6231c05bdcca

    changed the -fcf-protection behavior such that

    -fcf-protection -fcf-protection=branch

    is treated the same as

    -fcf-protection

    Use

    -fcf-protection -fcf-protection=none -fcf-protection=branch

    as the workaround.  This fixes BZ #31187.

    Tested with GCC 13 and GCC 14 on Intel Tiger Lake.
    Reviewed-by: Noah Goldstein <goldstein.w.n@gmail.com>

-- 
You are receiving this mail because:
You are on the CC list for the bug.

  reply	other threads:[~2024-01-01 23:56 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-12-22 16:27 [Bug dynamic-link/31187] New: " hjl.tools at gmail dot com
2024-01-01 23:56 ` cvs-commit at gcc dot gnu.org [this message]
2024-01-01 23:58 ` [Bug dynamic-link/31187] " hjl.tools at gmail dot com

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bug-31187-131-KtGlM9AUYR@http.sourceware.org/bugzilla/ \
    --to=sourceware-bugzilla@sourceware.org \
    --cc=glibc-bugs@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).