From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: by sourceware.org (Postfix, from userid 48) id 3BDD73858CDA; Mon, 29 Jan 2024 12:54:25 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 3BDD73858CDA DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1706532865; bh=bEog53c+tYisduPzIv+Ot44TJqsMmuG+eW/EZmXN0go=; h=From:To:Subject:Date:In-Reply-To:References:From; b=CHNAswm3BwWi6apYIUXQSNfqb4GCO8BHjBqH8I0Jj5zFQko6PoiZCL6O4azD+kki5 /0NotuwxINzlIEUllOl1Bwm4JqowsIYdoBLWolDaiYIZemDcighK7YU7WPnLPa/oBz H3W/ftpJ5SLFxJD+hQ0BQ844V10EYuaqGaIfUrPQ= From: "adhemerval.zanella at linaro dot org" To: glibc-bugs@sourceware.org Subject: [Bug build/31196] master fails to build on s390 with --disable-multi-arch Date: Mon, 29 Jan 2024 12:54:23 +0000 X-Bugzilla-Reason: CC X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: glibc X-Bugzilla-Component: build X-Bugzilla-Version: 2.38 X-Bugzilla-Keywords: X-Bugzilla-Severity: normal X-Bugzilla-Who: adhemerval.zanella at linaro dot org X-Bugzilla-Status: NEW X-Bugzilla-Resolution: X-Bugzilla-Priority: P2 X-Bugzilla-Assigned-To: unassigned at sourceware dot org X-Bugzilla-Target-Milestone: --- X-Bugzilla-Flags: security- X-Bugzilla-Changed-Fields: cc Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: http://sourceware.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 List-Id: https://sourceware.org/bugzilla/show_bug.cgi?id=3D31196 Adhemerval Zanella changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |adhemerval.zanella at lina= ro dot o | |rg --- Comment #5 from Adhemerval Zanella --- The recent s390 string refactor assumed multiarch/ifunc support as default = and organized the internal code without placing the ifunc selector/variants onl= y on multiarch folder. This is to allow the avoid ifunc and some string variants depending of the default compiler optimization (so if you target glibc to a z13, there is no need to provide old z900 variants and glibc internally can assume the z13 variants as default). I am not very found of this s390-specific organization, it differs from oth= er ports where there is no need to extra internal checks to see if you are building with multiarch support (USE_MULTIARCH). The following patch should= fix s390 and s390x, but I think it would be better to make s390 follow current practice of putting ifunc support only at multiarch folders. diff --git a/sysdeps/s390/memrchr-c.c b/sysdeps/s390/memrchr-c.c index bdf3c7bbe0..3cb27b795d 100644 --- a/sysdeps/s390/memrchr-c.c +++ b/sysdeps/s390/memrchr-c.c @@ -25,7 +25,7 @@ # include -# if defined SHARED && IS_IN (libc) +# if defined SHARED && IS_IN (libc) && defined USE_MULTIARCH __hidden_ver1 (__memrchr_c, __GI___memrchr, __memrchr_c); # endif #endif diff --git a/sysdeps/s390/strchrnul-c.c b/sysdeps/s390/strchrnul-c.c index f6f5bae311..cee0e1a89e 100644 --- a/sysdeps/s390/strchrnul-c.c +++ b/sysdeps/s390/strchrnul-c.c @@ -24,7 +24,7 @@ # endif # include -# if defined SHARED && IS_IN (libc) +# if defined SHARED && IS_IN (libc) && defined USE_MULTIARCH __hidden_ver1 (__strchrnul_c, __GI___strchrnul, __strchrnul_c); # endif #endif --=20 You are receiving this mail because: You are on the CC list for the bug.=