public inbox for glibc-bugs@sourceware.org
help / color / mirror / Atom feed
From: "carlos at redhat dot com" <sourceware-bugzilla@sourceware.org>
To: glibc-bugs@sourceware.org
Subject: [Bug libc/31286] New: glibc 2.36: Aliasing violation in libio/iovdprintf.c before refactor to internal buffers
Date: Wed, 24 Jan 2024 04:27:39 +0000	[thread overview]
Message-ID: <bug-31286-131@http.sourceware.org/bugzilla/> (raw)

https://sourceware.org/bugzilla/show_bug.cgi?id=31286

            Bug ID: 31286
           Summary: glibc 2.36: Aliasing violation in libio/iovdprintf.c
                    before refactor to internal buffers
           Product: glibc
           Version: 2.36
            Status: NEW
          Severity: normal
          Priority: P2
         Component: libc
          Assignee: unassigned at sourceware dot org
          Reporter: carlos at redhat dot com
                CC: drepper.fsp at gmail dot com
  Target Milestone: ---

In libio/iovdprintf.c in glibc 2.36 (before
8ece45e4f586abd212d1c02d74d38ef681a45600 and the conversion to internal
buffers):

 58 
 59   _IO_FINISH (&tmpfil.file);
 60 

The macro casts from the first member to the outer containing struct.

 92 /* Essentially ((TYPE *) THIS)->MEMBER, but avoiding the aliasing
 93    violation in case THIS has a different pointer type.  */
 94 #define _IO_CAST_FIELD_ACCESS(THIS, TYPE, MEMBER) \
 95   (*(_IO_MEMBER_TYPE (TYPE, MEMBER) *)(((char *) (THIS)) \
 96                                        + offsetof(TYPE, MEMBER)))

This works but some downstream pointer provenance checking tooling raises this
as an error.

It really should have been '_IO_FINISH (&tmpfil)'

-- 
You are receiving this mail because:
You are on the CC list for the bug.

             reply	other threads:[~2024-01-24  4:27 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-01-24  4:27 carlos at redhat dot com [this message]
2024-01-25 10:47 ` [Bug libc/31286] " sam at gentoo dot org
2024-01-25 12:32 ` carlos at redhat dot com
2024-01-25 16:52 ` fweimer at redhat dot com
2024-02-15 18:16 ` sam at gentoo dot org

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bug-31286-131@http.sourceware.org/bugzilla/ \
    --to=sourceware-bugzilla@sourceware.org \
    --cc=glibc-bugs@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).