public inbox for glibc-bugs@sourceware.org
help / color / mirror / Atom feed
From: "fweimer at redhat dot com" <sourceware-bugzilla@sourceware.org>
To: glibc-bugs@sourceware.org
Subject: [Bug build/31316] Fails test misc/tst-dirname "Didn't expect signal from child: got `Illegal instruction'" on non SSE CPUs
Date: Tue, 13 Feb 2024 17:48:32 +0000	[thread overview]
Message-ID: <bug-31316-131-h9G2rTJRpy@http.sourceware.org/bugzilla/> (raw)
In-Reply-To: <bug-31316-131@http.sourceware.org/bugzilla/>

https://sourceware.org/bugzilla/show_bug.cgi?id=31316

--- Comment #7 from Florian Weimer <fweimer at redhat dot com> ---
These diagnostics look fine.

I think the issue is that in sysdeps/i386/i686/multiarch/memrchr-sse2.S, we
have

strong_alias (__memrchr_sse2, __GI___memrchr)

under #if IS_IN (libc). This unconditionally sets the default implementation
for libc.so.6 to the SSE2 one. That should probably be in
sysdeps/i386/i686/multiarch/memrchr-c.c, for __memrchr_ia32.

Completely untested:

diff --git a/sysdeps/i386/i686/multiarch/memrchr-c.c
b/sysdeps/i386/i686/multiarch/memrchr-c.c
index ef7bbbe792..20bfdf3af3 100644
--- a/sysdeps/i386/i686/multiarch/memrchr-c.c
+++ b/sysdeps/i386/i686/multiarch/memrchr-c.c
@@ -5,3 +5,4 @@ extern void *__memrchr_ia32 (const void *, int, size_t);
 #endif

 #include "string/memrchr.c"
+strong_alias (__memrchr_ia32, __GI___memrchr)
diff --git a/sysdeps/i386/i686/multiarch/memrchr-sse2.S
b/sysdeps/i386/i686/multiarch/memrchr-sse2.S
index d9dae04171..e123f87435 100644
--- a/sysdeps/i386/i686/multiarch/memrchr-sse2.S
+++ b/sysdeps/i386/i686/multiarch/memrchr-sse2.S
@@ -720,5 +720,4 @@ L(ret_null):
        ret

 END (__memrchr_sse2)
-strong_alias (__memrchr_sse2, __GI___memrchr)
 #endif

-- 
You are receiving this mail because:
You are on the CC list for the bug.

  parent reply	other threads:[~2024-02-13 17:48 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-01-30  3:05 [Bug build/31316] New: " immoloism at googlemail dot com
2024-01-30  3:06 ` [Bug build/31316] " immoloism at googlemail dot com
2024-01-30  3:19 ` immoloism at googlemail dot com
2024-01-30  3:22 ` immoloism at googlemail dot com
2024-01-30 11:55 ` fweimer at redhat dot com
2024-02-13 17:21 ` sam at gentoo dot org
2024-02-13 17:25 ` fweimer at redhat dot com
2024-02-13 17:27 ` sam at gentoo dot org
2024-02-13 17:28 ` sam at gentoo dot org
2024-02-13 17:41 ` sam at gentoo dot org
2024-02-13 17:42 ` sam at gentoo dot org
2024-02-13 17:48 ` fweimer at redhat dot com [this message]
2024-02-15 14:05 ` sam at gentoo dot org
2024-02-15 14:50 ` fweimer at redhat dot com
2024-02-16  6:42 ` fweimer at redhat dot com

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bug-31316-131-h9G2rTJRpy@http.sourceware.org/bugzilla/ \
    --to=sourceware-bugzilla@sourceware.org \
    --cc=glibc-bugs@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).