[Bug dynamic-link/31317] [RISCV] static PIE crashes during self relocation

["palmer at gcc dot gnu.org" <sourceware-bugzilla@sourceware.org>]

https://sourceware.org/bugzilla/show_bug.cgi?id=31317

Palmer Dabbelt <palmer at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |palmer at gcc dot gnu.org

--- Comment #1 from Palmer Dabbelt <palmer at gcc dot gnu.org> ---
IIUC this is an ABI grey area.  I guess we could write down this as a
requirement and then call it a mold bug, but it seems better to just stop
taking advantage of the behavior if we can.  I guess something like

diff --git a/sysdeps/riscv/dl-machine.h b/sysdeps/riscv/dl-machine.h
index 0cbb476c05..a540760f6f 100644
--- a/sysdeps/riscv/dl-machine.h
+++ b/sysdeps/riscv/dl-machine.h
@@ -348,7 +348,7 @@ elf_machine_runtime_setup (struct link_map *l, struct
r_scope_elem *scope[],
       gotplt[1] = (ElfW(Addr)) l;
     }

-  if (l->l_type == lt_executable && l->l_scope != NULL)
+  if (l->l_type == lt_executable && l->l_relocated && l->l_scope != NULL)
     {
       /* The __global_pointer$ may not be defined by the linker if the
         $gp register does not be used to access the global variable

would squash the crash.  Maybe that's good enough for static-PIE?  We also load
up GP in _start, and it's not like MIPS where we have per-object GP values so I
think we should be safe?

-- 
You are receiving this mail because:
You are on the CC list for the bug.