public inbox for glibc-bugs@sourceware.org help / color / mirror / Atom feed
From: "adrian.ratiu at collabora dot com" <sourceware-bugzilla@sourceware.org> To: glibc-bugs@sourceware.org Subject: [Bug libc/31339] New: arm32 loader crash after cleanup in 2.36 Date: Mon, 05 Feb 2024 11:44:13 +0000 [thread overview] Message-ID: <bug-31339-131@http.sourceware.org/bugzilla/> (raw) https://sourceware.org/bugzilla/show_bug.cgi?id=31339 Bug ID: 31339 Summary: arm32 loader crash after cleanup in 2.36 Product: glibc Version: unspecified Status: UNCONFIRMED Severity: normal Priority: P2 Component: libc Assignee: unassigned at sourceware dot org Reporter: adrian.ratiu at collabora dot com CC: drepper.fsp at gmail dot com Target Milestone: --- Hello, An ARM32 loader crash was noticed while upgrading glibc in ChromiumOS, which George, (added to CC), tracked down to this cleanup commit: https://sourceware.org/git/?p=glibc.git;a=commit;h=49d877a80b29d3002887b084eec6676d9f5fec18 In a nutshell, we believe that commit forgot to remove an unnecessary "ldr r4, [sl, r4]" in _dl_start_user which causes programs to crash because, according to the arm32 ABI, r4 is a caller-saved register, so using its value after the above cleanup commit doesn't make much sense, as the commit removed its initialization. Also the result of this ldr is not used, which is a further indication this crashing instruction was missed during the cleanup. George applied the following patch which fixed the crash in CrOS: diff --git a/sysdeps/arm/dl-machine.h b/sysdeps/arm/dl-machine.h index b857bbc868..dd1a0f6b6e 100644 --- a/sysdeps/arm/dl-machine.h +++ b/sysdeps/arm/dl-machine.h @@ -139,7 +139,6 @@ _start:\n\ _dl_start_user:\n\ adr r6, .L_GET_GOT\n\ add sl, sl, r6\n\ - ldr r4, [sl, r4]\n\ @ save the entry point in another register\n\ mov r6, r0\n\ @ get the original arg count\n\ Can glibc please also apply this fix? The original debugging/investigation into this issue is public, though it requires a google/gmail account: https://issuetracker.google.com/u/1/issues/322172904 Thank you, Adrian -- You are receiving this mail because: You are on the CC list for the bug.
next reply other threads:[~2024-02-05 11:44 UTC|newest] Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top 2024-02-05 11:44 adrian.ratiu at collabora dot com [this message] 2024-02-05 11:48 ` [Bug libc/31339] " adrian.ratiu at collabora dot com 2024-02-05 14:38 ` adhemerval.zanella at linaro dot org 2024-02-05 15:57 ` adrian.ratiu at collabora dot com 2024-02-05 18:44 ` adhemerval.zanella at linaro dot org
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=bug-31339-131@http.sourceware.org/bugzilla/ \ --to=sourceware-bugzilla@sourceware.org \ --cc=glibc-bugs@sourceware.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).