From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <sourceware-bugzilla@sourceware.org>
Received: by sourceware.org (Postfix, from userid 48)
	id 7A4EA3861865; Thu, 15 Feb 2024 11:13:56 +0000 (GMT)
DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 7A4EA3861865
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org;
	s=default; t=1707995636;
	bh=AUwn+fH1Nso+WZSmu+ODTXdicxy5HPy8tc3fccaEjd8=;
	h=From:To:Subject:Date:From;
	b=a0RVXdLG3hvnCL7VEJrKbMfvC2ragH3smmnZUYMdEBH2YLKBTwNFvOkmBW2BQJ69A
	 2ZhofFB+STQJmBhC4szL07QU3EreSYJueXBv/QarVJmMkZdo/M4k+sMnE6ZRHTnIJS
	 KVuw4T5QJt2R8TtyCyty16uuJQTbDNRk9e/Dsz/8=
From: "hjl.tools at gmail dot com" <sourceware-bugzilla@sourceware.org>
To: glibc-bugs@sourceware.org
Subject: [Bug build/31385] New: sort-makefile-lines.py doesn't check variable
 with _
Date: Thu, 15 Feb 2024 11:13:55 +0000
X-Bugzilla-Reason: CC
X-Bugzilla-Type: new
X-Bugzilla-Watch-Reason: None
X-Bugzilla-Product: glibc
X-Bugzilla-Component: build
X-Bugzilla-Version: 2.40
X-Bugzilla-Keywords: 
X-Bugzilla-Severity: normal
X-Bugzilla-Who: hjl.tools at gmail dot com
X-Bugzilla-Status: NEW
X-Bugzilla-Resolution: 
X-Bugzilla-Priority: P2
X-Bugzilla-Assigned-To: unassigned at sourceware dot org
X-Bugzilla-Target-Milestone: ---
X-Bugzilla-Flags: 
X-Bugzilla-Changed-Fields: bug_id short_desc product version bug_status
 bug_severity priority component assigned_to reporter cc target_milestone
Message-ID: <bug-31385-131@http.sourceware.org/bugzilla/>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
X-Bugzilla-URL: http://sourceware.org/bugzilla/
Auto-Submitted: auto-generated
MIME-Version: 1.0
List-Id: <glibc-bugs.sourceware.org>

https://sourceware.org/bugzilla/show_bug.cgi?id=3D31385

            Bug ID: 31385
           Summary: sort-makefile-lines.py doesn't check variable with _
           Product: glibc
           Version: 2.40
            Status: NEW
          Severity: normal
          Priority: P2
         Component: build
          Assignee: unassigned at sourceware dot org
          Reporter: hjl.tools at gmail dot com
                CC: carlos at redhat dot com
  Target Milestone: ---

There are many Makefile variable names with _:

sysdeps/aarch64/Makefile:sysdep_headers +=3D sys/ifunc.h
sysdeps/aarch64/Makefile:sysdep_routines +=3D \
sysdeps/aarch64/Makefile:sysdep_malloc_debug_routines =3D __mtag_tag_zero_r=
egion
__mtag_tag_region
...

But sort-makefile-lines.py doesn't include _ in

    # Build a list of all start markers (tuple includes name).
    startmarks =3D []
    for i in range(len(lines)):
        # Look for things like "var =3D \", "var :=3D \" or "var +=3D \"
        # to start the sorted list.
        var =3D re.search(r'^([a-zA-Z0-9-]*) [\+:]?\=3D \\$', lines[i])

--=20
You are receiving this mail because:
You are on the CC list for the bug.=