From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <sourceware-bugzilla@sourceware.org>
Received: by sourceware.org (Postfix, from userid 48)
	id 95C54385841E; Wed, 13 Mar 2024 10:28:30 +0000 (GMT)
DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 95C54385841E
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org;
	s=default; t=1710325710;
	bh=qQmyCw1TaMzBhNwKEST5tQiWlf3xBaASWHPNTujBAF0=;
	h=From:To:Subject:Date:From;
	b=Swr7/GD6JgBrTfdI3B73QCc+X9Pbh3v0BNCOT3SPjd+Lk7No4bu6/tQmkmt7GVCL4
	 bLFr6Gs70C4NGdW/kXzz3NV/8Aee9HXBhgqoPA9IzihGKKuNoZ+sFRyb4yZgdFLqWY
	 1rk9stSMKeM58tq78GIzi5FOUzihnKmf2mPsAA6g=
From: "fweimer at redhat dot com" <sourceware-bugzilla@sourceware.org>
To: glibc-bugs@sourceware.org
Subject: [Bug libc/31479] New: Missing #include <sys/rseq.h> in
 sched_getcpu.c may result in a loss of rseq acceleration
Date: Wed, 13 Mar 2024 10:28:30 +0000
X-Bugzilla-Reason: CC
X-Bugzilla-Type: new
X-Bugzilla-Watch-Reason: None
X-Bugzilla-Product: glibc
X-Bugzilla-Component: libc
X-Bugzilla-Version: 2.35
X-Bugzilla-Keywords: 
X-Bugzilla-Severity: normal
X-Bugzilla-Who: fweimer at redhat dot com
X-Bugzilla-Status: NEW
X-Bugzilla-Resolution: 
X-Bugzilla-Priority: P2
X-Bugzilla-Assigned-To: unassigned at sourceware dot org
X-Bugzilla-Target-Milestone: ---
X-Bugzilla-Flags: 
X-Bugzilla-Changed-Fields: bug_id short_desc product version bug_status
 bug_severity priority component assigned_to reporter cc target_milestone
Message-ID: <bug-31479-131@http.sourceware.org/bugzilla/>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
X-Bugzilla-URL: http://sourceware.org/bugzilla/
Auto-Submitted: auto-generated
MIME-Version: 1.0
List-Id: <glibc-bugs.sourceware.org>

https://sourceware.org/bugzilla/show_bug.cgi?id=3D31479

            Bug ID: 31479
           Summary: Missing #include <sys/rseq.h> in sched_getcpu.c may
                    result in a loss of rseq acceleration
           Product: glibc
           Version: 2.35
            Status: NEW
          Severity: normal
          Priority: P2
         Component: libc
          Assignee: unassigned at sourceware dot org
          Reporter: fweimer at redhat dot com
                CC: drepper.fsp at gmail dot com
  Target Milestone: ---

This commit removed #include <sys/rseq.h> from nptl/descr.h:

commit 2c6b4b272e6b4d07303af25709051c3e96288f2d
Author: Florian Weimer <fweimer@redhat.com>
Date:   Fri Jul 21 16:18:18 2023 +0200

    nptl: Unconditionally use a 32-byte rseq area

    If the kernel headers provide a larger struct rseq, we used that
    size as the argument to the rseq system call.  As a result,
    rseq registration would fail on older kernels which only accept
    size 32.

As a result, <sys/rseq.h> may or may not be implicitly included when
sysdeps/unix/sysv/linux/sched_getcpu.c is built. If <sys/rseq.h> is not
included, RSEQ_SIG is not defined, and we do not get rseq acceleration even=
 if
supported on the architecture.

--=20
You are receiving this mail because:
You are on the CC list for the bug.=