public inbox for glibc-bugs@sourceware.org
help / color / mirror / Atom feed
From: "simon.chopin at canonical dot com" <sourceware-bugzilla@sourceware.org>
To: glibc-bugs@sourceware.org
Subject: [Bug time/31510] New: Wrong type for timeval.tv_usec on 32-bit archs with _TIME_BITS=64
Date: Tue, 19 Mar 2024 11:24:14 +0000	[thread overview]
Message-ID: <bug-31510-131@http.sourceware.org/bugzilla/> (raw)

https://sourceware.org/bugzilla/show_bug.cgi?id=31510

            Bug ID: 31510
           Summary: Wrong type for timeval.tv_usec on 32-bit archs with
                    _TIME_BITS=64
           Product: glibc
           Version: unspecified
            Status: UNCONFIRMED
          Severity: normal
          Priority: P2
         Component: time
          Assignee: unassigned at sourceware dot org
          Reporter: simon.chopin at canonical dot com
  Target Milestone: ---

POSIX documents struct timeval as follows:

struct timeval {
    time_t      tv_sec;         /* seconds */
    suseconds_t tv_usec;        /* microseconds */
};
Since bdc4782744df73a8c0559985c54b5b6b9c7a4a74 ("y2038: Add __USE_TIME_BITS64
support for struct timeval") tv_usec can have __suseconds64_t when using 64-bit
time, however suseconds_t is unconditionally typedefed to __suseconds_t.

That leads to the following:

ubuntu@mantic-armhf:~$ cat test.c
#include <sys/time.h>
#include <stdio.h>
#include <assert.h>

int main(void)
{
        struct timeval tv;
        printf("tv_usec: %d, suseconds_t: %d\n", sizeof(tv.tv_usec),
sizeof(suseconds_t));
        assert(sizeof(tv.tv_usec) == sizeof(suseconds_t));
        return 0;
}
ubuntu@mantic-armhf:~$ gcc test.c && ./a.out
tv_usec: 4, suseconds_t: 4
ubuntu@mantic-armhf:~$ gcc -D_TIME_BITS=64 -D_FILE_OFFSET_BITS=64 test.c &&
./a.out
tv_usec: 8, suseconds_t: 4
a.out: test.c:9: main: Assertion `sizeof(tv.tv_usec) == sizeof(suseconds_t)'
failed.
Aborted (core dumped)

We noticed this when running the conformance tests on Ubuntu Noble, where we've
set _TIME_BITS=64 in the default GCC flags as part of the ongoing t64
transition.

-- 
You are receiving this mail because:
You are on the CC list for the bug.

             reply	other threads:[~2024-03-19 11:24 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-03-19 11:24 simon.chopin at canonical dot com [this message]
2024-03-19 11:30 ` [Bug time/31510] " sam at gentoo dot org
2024-03-19 12:15 ` adhemerval.zanella at linaro dot org
2024-03-19 20:21 ` jsm28 at gcc dot gnu.org
2024-03-19 20:22 ` jsm28 at gcc dot gnu.org
2024-03-20 12:27 ` adhemerval.zanella at linaro dot org
2024-03-20 13:48 ` simon.chopin at canonical dot com

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bug-31510-131@http.sourceware.org/bugzilla/ \
    --to=sourceware-bugzilla@sourceware.org \
    --cc=glibc-bugs@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).