[Bug nscd/31679] nscd: netgroup cache may terminate daemon on memory allocation failure

["carlos at redhat dot com" <sourceware-bugzilla@sourceware.org>]

https://sourceware.org/bugzilla/show_bug.cgi?id=31679

--- Comment #2 from Carlos O'Donell <carlos at redhat dot com> ---
(In reply to Carlos O'Donell from comment #1)
> [carlos@athas nscd]$ grep 'xmalloc' *
> Makefile:# To find xmalloc.c
> Makefile:		xmalloc xstrdup aicache initgrcache res_hconf \
> connections.c:	    dbs[cnt].head = xmalloc (sizeof (struct
> database_pers_head)
> connections.c:	    dbs[cnt].data = xmalloc (dbs[cnt].head->data_size);
> connections.c:  struct pollfd *conns = (struct pollfd *) xmalloc (nconns
> connections.c:  server_groups = (gid_t *) xmalloc (server_ngroups * sizeof
> (gid_t));
> mem.c:      he = xmalloc (memory_needed);
> mem.c:#define obstack_chunk_alloc xmalloc
> netgroupcache.c:  buffer = xmalloc (buflen);
> nscd.h:#include <programs/xmalloc.h>
> [carlos@athas nscd]$ grep 'xrealloc' *
> netgroupcache.c:				    char *newbuf = xrealloc (buffer, buflen);
> netgroupcache.c:			*tofreep = buffer = xrealloc (buffer, buflen);
> 
> Yes, we should not be doing this anywhere, we should check the result and
> handle the OOM gracefully.

I should note that this bug is only about the netgroupcache.c usage.

-- 
You are receiving this mail because:
You are on the CC list for the bug.