From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <sourceware-bugzilla@sourceware.org>
Received: by sourceware.org (Postfix, from userid 48)
	id D595A3858D28; Sun,  9 Jun 2024 08:39:54 +0000 (GMT)
DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org D595A3858D28
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org;
	s=default; t=1717922394;
	bh=Fnsdc4kX6+zOmHnGaiFK3KPHQiSGhSUoNdq5VSaPtM8=;
	h=From:To:Subject:Date:In-Reply-To:References:From;
	b=NjhUReMbHfBLZeTBC2zBUSxC5UKC9jsR4Lobt7wqwPVkDUMwjWT2NglHsXlyrMXWN
	 EDEiFEV7uWy9vSuZsvwK4VWtY6GjMjEVhw/q/M39MiCcSt7wFRbylKdocTkOJscmfu
	 ut34MggK8rGoYo1qZxKW0sTnWjTDYhU+MjQf63VQ=
From: "sam at gentoo dot org" <sourceware-bugzilla@sourceware.org>
To: glibc-bugs@sourceware.org
Subject: [Bug build/31867] "CPU ISA level is lower than required" on
 SSE2-free CPUs
Date: Sun, 09 Jun 2024 08:39:54 +0000
X-Bugzilla-Reason: CC
X-Bugzilla-Type: changed
X-Bugzilla-Watch-Reason: None
X-Bugzilla-Product: glibc
X-Bugzilla-Component: build
X-Bugzilla-Version: unspecified
X-Bugzilla-Keywords: 
X-Bugzilla-Severity: normal
X-Bugzilla-Who: sam at gentoo dot org
X-Bugzilla-Status: NEW
X-Bugzilla-Resolution: 
X-Bugzilla-Priority: P2
X-Bugzilla-Assigned-To: unassigned at sourceware dot org
X-Bugzilla-Target-Milestone: ---
X-Bugzilla-Flags: 
X-Bugzilla-Changed-Fields: 
Message-ID: <bug-31867-131-pRwVevoBcO@http.sourceware.org/bugzilla/>
In-Reply-To: <bug-31867-131@http.sourceware.org/bugzilla/>
References: <bug-31867-131@http.sourceware.org/bugzilla/>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
X-Bugzilla-URL: http://sourceware.org/bugzilla/
Auto-Submitted: auto-generated
MIME-Version: 1.0
List-Id: <glibc-bugs.sourceware.org>

https://sourceware.org/bugzilla/show_bug.cgi?id=3D31867

--- Comment #1 from Sam James <sam at gentoo dot org> ---
In sysdeps/x86/isa-level.h, we correctly do:
```
#if defined __SSE__ && defined __SSE2__
/* NB: ISAs, excluding MMX, in x86-64 ISA level baseline are used.  */
# define __X86_ISA_V1 1
#else
# define __X86_ISA_V1 0
#endif
```

But when we run the configure test, we do...
```
cat > conftest.c <<EOF
#include <sysdeps/x86/isa-level.h>
#if MINIMUM_X86_ISA_LEVEL >=3D 4
libc_cv_have_x86_isa_level=3D4
#elif MINIMUM_X86_ISA_LEVEL =3D=3D 3
libc_cv_have_x86_isa_level=3D3
#elif MINIMUM_X86_ISA_LEVEL =3D=3D 2
libc_cv_have_x86_isa_level=3D2
#else
libc_cv_have_x86_isa_level=3Dbaseline
#endif
EOF
```

On a CPU without SSE2, we will get 'baseline', and then...

```
if test $libc_cv_have_x86_isa_level =3D baseline; then
AC_DEFINE_UNQUOTED(MINIMUM_X86_ISA_LEVEL, 1)
else
AC_DEFINE_UNQUOTED(MINIMUM_X86_ISA_LEVEL, $libc_cv_have_x86_isa_level)
fi
```

We set MINIMUM_X86_ISA_LEVEL to 1, not 0, which seems wrong.

--=20
You are receiving this mail because:
You are on the CC list for the bug.=