public inbox for glibc-bugs@sourceware.org
help / color / mirror / Atom feed
From: "fweimer at redhat dot com" <sourceware-bugzilla@sourceware.org>
To: glibc-bugs@sourceware.org
Subject: [Bug libc/31968] New: mremap implementation in C does not handle arguments correctly
Date: Tue, 09 Jul 2024 13:57:29 +0000	[thread overview]
Message-ID: <bug-31968-131@http.sourceware.org/bugzilla/> (raw)

https://sourceware.org/bugzilla/show_bug.cgi?id=31968

            Bug ID: 31968
           Summary: mremap implementation in C does not handle arguments
                    correctly
           Product: glibc
           Version: 2.35
            Status: NEW
          Severity: normal
          Priority: P2
         Component: libc
          Assignee: unassigned at sourceware dot org
          Reporter: fweimer at redhat dot com
                CC: drepper.fsp at gmail dot com
  Target Milestone: ---

Conditional varargs processing for system calls is bad.  It causes an ongoing
maintenance headache, and weird application issues.  For example, Linux 5.7
added MREMAP_DONTUNMAP, and it can use the address argument just like
MREMAP_FIXED.  But the current mremap implementation always passes NULL as a
system call argument.

Regression in 2.35 caused by:

commit 5b3e31e3124bf89710e5c25176c70fdf66c2a212
Author: Adhemerval Zanella <adhemerval.zanella@linaro.org>
Date:   Wed Jun 17 09:29:07 2020 -0300

    linux: Implement mremap in C

    Variadic function calls in syscalls.list does not work for all ABIs
    (for instance where the argument are passed on the stack instead of
    registers) and might have underlying issues depending of the variadic
    type (for instance if a 64-bit argument is used).

    Checked on x86_64-linux-gnu.

-- 
You are receiving this mail because:
You are on the CC list for the bug.

             reply	other threads:[~2024-07-09 13:57 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-07-09 13:57 fweimer at redhat dot com [this message]
2024-07-09 13:57 ` [Bug libc/31968] " fweimer at redhat dot com
2024-07-09 13:58 ` fweimer at redhat dot com
2024-07-09 15:01 ` fweimer at redhat dot com
2024-07-09 22:13 ` hjl.tools at gmail dot com
2024-07-11  3:21 ` hjl.tools at gmail dot com
2024-07-12 22:38 ` hjl.tools at gmail dot com
2024-07-12 22:39 ` hjl.tools at gmail dot com
2024-08-01 12:10 ` cvs-commit at gcc dot gnu.org
2024-08-01 12:38 ` cvs-commit at gcc dot gnu.org
2024-08-01 12:39 ` cvs-commit at gcc dot gnu.org
2024-08-01 13:00 ` cvs-commit at gcc dot gnu.org
2024-08-01 15:15 ` cvs-commit at gcc dot gnu.org
2024-08-01 15:16 ` cvs-commit at gcc dot gnu.org
2024-08-01 15:30 ` cvs-commit at gcc dot gnu.org
2024-09-06 14:33 ` fweimer at redhat dot com

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bug-31968-131@http.sourceware.org/bugzilla/ \
    --to=sourceware-bugzilla@sourceware.org \
    --cc=glibc-bugs@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).