public inbox for glibc-bugs@sourceware.org help / color / mirror / Atom feed
* [Bug nptl/32040] New: CPU affinity test skeleton for sched_setaffinity and pthread_setaffinity_np can fail to report failure. @ 2024-07-31 17:24 carlos at redhat dot com 2024-07-31 17:30 ` [Bug nptl/32040] " carlos at redhat dot com ` (2 more replies) 0 siblings, 3 replies; 4+ messages in thread From: carlos at redhat dot com @ 2024-07-31 17:24 UTC (permalink / raw) To: glibc-bugs https://sourceware.org/bugzilla/show_bug.cgi?id=32040 Bug ID: 32040 Summary: CPU affinity test skeleton for sched_setaffinity and pthread_setaffinity_np can fail to report failure. Product: glibc Version: 2.41 Status: NEW Severity: normal Priority: P2 Component: nptl Assignee: unassigned at sourceware dot org Reporter: carlos at redhat dot com CC: drepper.fsp at gmail dot com Target Milestone: --- The file sysdeps/unix/sysv/linux/tst-skeleton-affinity.c is used to implement the testing for sched_setaffinity and pthread_setaffiniyt_np, among various APIs. In the "test_size" routine we have this code: 152 if (getaffinity (kernel_size, initial_set) < 0) 153 { 154 printf ("error: size %zu: getaffinity: %m\n", size); 155 return false; 156 } 157 if (setaffinity (kernel_size, initial_set) < 0) 158 { 159 printf ("error: size %zu: setaffinity: %m\n", size); 160 return true; 161 } The point being that you should be able to get, and then set the affinity of the process (they should match) and this should be idempotent for the test. But in the "setaffinity" case we "return true;" on error which skips the rest of the tests and silently doesn't report the error. This looks like a typo, and it should be "return false;" for this case? -- You are receiving this mail because: You are on the CC list for the bug. ^ permalink raw reply [flat|nested] 4+ messages in thread
* [Bug nptl/32040] CPU affinity test skeleton for sched_setaffinity and pthread_setaffinity_np can fail to report failure. 2024-07-31 17:24 [Bug nptl/32040] New: CPU affinity test skeleton for sched_setaffinity and pthread_setaffinity_np can fail to report failure carlos at redhat dot com @ 2024-07-31 17:30 ` carlos at redhat dot com 2024-08-15 12:29 ` carlos at redhat dot com 2024-08-15 19:34 ` carlos at redhat dot com 2 siblings, 0 replies; 4+ messages in thread From: carlos at redhat dot com @ 2024-07-31 17:30 UTC (permalink / raw) To: glibc-bugs https://sourceware.org/bugzilla/show_bug.cgi?id=32040 Carlos O'Donell <carlos at redhat dot com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fweimer at redhat dot com -- You are receiving this mail because: You are on the CC list for the bug. ^ permalink raw reply [flat|nested] 4+ messages in thread
* [Bug nptl/32040] CPU affinity test skeleton for sched_setaffinity and pthread_setaffinity_np can fail to report failure. 2024-07-31 17:24 [Bug nptl/32040] New: CPU affinity test skeleton for sched_setaffinity and pthread_setaffinity_np can fail to report failure carlos at redhat dot com 2024-07-31 17:30 ` [Bug nptl/32040] " carlos at redhat dot com @ 2024-08-15 12:29 ` carlos at redhat dot com 2024-08-15 19:34 ` carlos at redhat dot com 2 siblings, 0 replies; 4+ messages in thread From: carlos at redhat dot com @ 2024-08-15 12:29 UTC (permalink / raw) To: glibc-bugs https://sourceware.org/bugzilla/show_bug.cgi?id=32040 --- Comment #1 from Carlos O'Donell <carlos at redhat dot com> --- Patch posted: https://patchwork.sourceware.org/project/glibc/patch/20240815122756.260740-1-carlos@redhat.com/ -- You are receiving this mail because: You are on the CC list for the bug. ^ permalink raw reply [flat|nested] 4+ messages in thread
* [Bug nptl/32040] CPU affinity test skeleton for sched_setaffinity and pthread_setaffinity_np can fail to report failure. 2024-07-31 17:24 [Bug nptl/32040] New: CPU affinity test skeleton for sched_setaffinity and pthread_setaffinity_np can fail to report failure carlos at redhat dot com 2024-07-31 17:30 ` [Bug nptl/32040] " carlos at redhat dot com 2024-08-15 12:29 ` carlos at redhat dot com @ 2024-08-15 19:34 ` carlos at redhat dot com 2 siblings, 0 replies; 4+ messages in thread From: carlos at redhat dot com @ 2024-08-15 19:34 UTC (permalink / raw) To: glibc-bugs https://sourceware.org/bugzilla/show_bug.cgi?id=32040 Carlos O'Donell <carlos at redhat dot com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|NEW |RESOLVED Target Milestone|--- |2.41 --- Comment #2 from Carlos O'Donell <carlos at redhat dot com> --- Fixed with b22923abb046311ac9097a36b97b9b97342bac44 -- You are receiving this mail because: You are on the CC list for the bug. ^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2024-08-15 19:34 UTC | newest] Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- 2024-07-31 17:24 [Bug nptl/32040] New: CPU affinity test skeleton for sched_setaffinity and pthread_setaffinity_np can fail to report failure carlos at redhat dot com 2024-07-31 17:30 ` [Bug nptl/32040] " carlos at redhat dot com 2024-08-15 12:29 ` carlos at redhat dot com 2024-08-15 19:34 ` carlos at redhat dot com
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).