[Bug libc/32052] New: stdlib.h's use of 'sz' identifier causes libstdc++ test failure

[Bug libc/32052] New: stdlib.h's use of 'sz' identifier causes libstdc++ test failure

[sam at gentoo dot org]

https://sourceware.org/bugzilla/show_bug.cgi?id=32052

            Bug ID: 32052
           Summary: stdlib.h's use of 'sz' identifier causes libstdc++
                    test failure
           Product: glibc
           Version: unspecified
            Status: NEW
          Severity: normal
          Priority: P2
         Component: libc
          Assignee: unassigned at sourceware dot org
          Reporter: sam at gentoo dot org
                CC: drepper.fsp at gmail dot com, pinskia at gcc dot gnu.org,
                    siddhesh at sourceware dot org
  Target Milestone: ---

See https://gcc.gnu.org/bugzilla/show_bug.cgi?id=116210.

a643f60c53876be0d57b4b7373770e6cb356fd13, with _FORTIFY_SOURCE, adds 'sz' which
ends up breaking libstdc++'s 17_intro/names.cc test.

I think we may end up having the same issue as with PR30516? Not sure as I've
~zero knowledge about C++ modules, cc'd pinskia for guidance.

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug libc/32052] stdlib.h's use of 'sz' identifier causes libstdc++ test failure

[sam at gentoo dot org]

https://sourceware.org/bugzilla/show_bug.cgi?id=32052

Sam James <sam at gentoo dot org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jwakely.gcc at gmail dot com

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug libc/32052] stdlib.h's use of 'sz' identifier causes libstdc++ test failure

[schwab@linux-m68k.org]

https://sourceware.org/bugzilla/show_bug.cgi?id=32052

Andreas Schwab <schwab@linux-m68k.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Version|unspecified                 |2.35
           See Also|https://sourceware.org/bugz |
                   |illa/show_bug.cgi?id=30516  |

--- Comment #1 from Andreas Schwab <schwab@linux-m68k.org> ---
It's a name space violation, it needs to be renamed to start with __.

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug libc/32052] stdlib.h's use of 'sz' identifier causes libstdc++ test failure

[fweimer at redhat dot com]

https://sourceware.org/bugzilla/show_bug.cgi?id=32052

Florian Weimer <fweimer at redhat dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |fweimer at redhat dot com
              Flags|                            |security-

--- Comment #2 from Florian Weimer <fweimer at redhat dot com> ---
(In reply to Andreas Schwab from comment #1)
> It's a name space violation, it needs to be renamed to start with __.

Agreed. Any idea why the namespace tests do not cache this?

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug libc/32052] stdlib.h's use of 'sz' identifier causes libstdc++ test failure

[sam at gentoo dot org]

https://sourceware.org/bugzilla/show_bug.cgi?id=32052

--- Comment #3 from Sam James <sam at gentoo dot org> ---
(In reply to Andreas Schwab from comment #1)
> It's a name space violation, it needs to be renamed to start with __.

Sorry, that's obvious now you say it.

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug libc/32052] stdlib.h's use of 'sz' identifier causes libstdc++ test failure

[schwab@linux-m68k.org]

https://sourceware.org/bugzilla/show_bug.cgi?id=32052

--- Comment #4 from Andreas Schwab <schwab@linux-m68k.org> ---
The namespace tests don't enable fortify.

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug libc/32052] stdlib.h's use of 'sz' identifier causes libstdc++ test failure

[sam at gentoo dot org]

https://sourceware.org/bugzilla/show_bug.cgi?id=32052

--- Comment #5 from Sam James <sam at gentoo dot org> ---

commit 39ca997ab378990d5ac1aadbaa52aaf1db6d526f
Author: Andreas Schwab <schwab@suse.de>
Date:   Mon Aug 5 10:55:51 2024 +0200

    Fix name space violation in fortify wrappers (bug 32052)

    Rename the identifier sz to __sz everywhere.

    Fixes: a643f60c53 ("Make sure that the fortified function conditionals are
constant")

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug libc/32052] stdlib.h's use of 'sz' identifier causes libstdc++ test failure

[sam at gentoo dot org]

https://sourceware.org/bugzilla/show_bug.cgi?id=32052

Sam James <sam at gentoo dot org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|---                         |2.41

--- Comment #6 from Sam James <sam at gentoo dot org> ---
Keeping open for backports. Florian indicated he'll handle that.

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug libc/32052] stdlib.h's use of 'sz' identifier causes libstdc++ test failure

[fweimer at redhat dot com]

https://sourceware.org/bugzilla/show_bug.cgi?id=32052

Florian Weimer <fweimer at redhat dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |FIXED
             Status|NEW                         |RESOLVED

--- Comment #7 from Florian Weimer <fweimer at redhat dot com> ---
Backporting is complete.

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug libc/32052] stdlib.h's use of 'sz' identifier causes libstdc++ test failure

[sam at gentoo dot org]

https://sourceware.org/bugzilla/show_bug.cgi?id=32052

Sam James <sam at gentoo dot org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://sourceware.org/bugz
                   |                            |illa/show_bug.cgi?id=32057

-- 
You are receiving this mail because:
You are on the CC list for the bug.