public inbox for glibc-bugs@sourceware.org
help / color / mirror / Atom feed
* [Bug libc/32126] New: readdir64_r: Do not skip entries with zero d_ino values
@ 2024-08-30  6:53 fweimer at redhat dot com
  2024-08-30  6:55 ` [Bug libc/32126] " fweimer at redhat dot com
                   ` (3 more replies)
  0 siblings, 4 replies; 5+ messages in thread
From: fweimer at redhat dot com @ 2024-08-30  6:53 UTC (permalink / raw)
  To: glibc-bugs

https://sourceware.org/bugzilla/show_bug.cgi?id=32126

            Bug ID: 32126
           Summary: readdir64_r: Do not skip entries with zero d_ino
                    values
           Product: glibc
           Version: unspecified
            Status: NEW
          Severity: normal
          Priority: P2
         Component: libc
          Assignee: unassigned at sourceware dot org
          Reporter: fweimer at redhat dot com
                CC: drepper.fsp at gmail dot com
  Target Milestone: ---

This is the same bug as bug 12165, but for the 64-bit versions of readdir_r.

The d_ino == 0 check needs to be removed:

diff --git a/sysdeps/unix/sysv/linux/readdir64_r.c
b/sysdeps/unix/sysv/linux/readdir64_r.c
index e87882ee06..168914ef67 100644
--- a/sysdeps/unix/sysv/linux/readdir64_r.c
+++ b/sysdeps/unix/sysv/linux/readdir64_r.c
@@ -95,10 +95,8 @@ __readdir64_r (DIR *dirp, struct dirent64 *entry, struct
dirent64 **result)
              continue;
            }
        }
-
-      /* Skip deleted and ignored files.  */
     }
-  while (dp->d_ino == 0);
+  while (0);

   if (dp != NULL)
     {

-- 
You are receiving this mail because:
You are on the CC list for the bug.

^ permalink raw reply	[flat|nested] 5+ messages in thread

* [Bug libc/32126] readdir64_r: Do not skip entries with zero d_ino values
  2024-08-30  6:53 [Bug libc/32126] New: readdir64_r: Do not skip entries with zero d_ino values fweimer at redhat dot com
@ 2024-08-30  6:55 ` fweimer at redhat dot com
  2024-08-30  8:20 ` sam at gentoo dot org
                   ` (2 subsequent siblings)
  3 siblings, 0 replies; 5+ messages in thread
From: fweimer at redhat dot com @ 2024-08-30  6:55 UTC (permalink / raw)
  To: glibc-bugs

https://sourceware.org/bugzilla/show_bug.cgi?id=32126

Florian Weimer <fweimer at redhat dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|unassigned at sourceware dot org   |fweimer at redhat dot com
                 CC|                            |fweimer at redhat dot com
             Status|NEW                         |ASSIGNED

-- 
You are receiving this mail because:
You are on the CC list for the bug.

^ permalink raw reply	[flat|nested] 5+ messages in thread

* [Bug libc/32126] readdir64_r: Do not skip entries with zero d_ino values
  2024-08-30  6:53 [Bug libc/32126] New: readdir64_r: Do not skip entries with zero d_ino values fweimer at redhat dot com
  2024-08-30  6:55 ` [Bug libc/32126] " fweimer at redhat dot com
@ 2024-08-30  8:20 ` sam at gentoo dot org
  2024-09-21 17:37 ` cvs-commit at gcc dot gnu.org
  2024-09-21 17:38 ` fweimer at redhat dot com
  3 siblings, 0 replies; 5+ messages in thread
From: sam at gentoo dot org @ 2024-08-30  8:20 UTC (permalink / raw)
  To: glibc-bugs

https://sourceware.org/bugzilla/show_bug.cgi?id=32126

Sam James <sam at gentoo dot org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |sam at gentoo dot org

-- 
You are receiving this mail because:
You are on the CC list for the bug.

^ permalink raw reply	[flat|nested] 5+ messages in thread

* [Bug libc/32126] readdir64_r: Do not skip entries with zero d_ino values
  2024-08-30  6:53 [Bug libc/32126] New: readdir64_r: Do not skip entries with zero d_ino values fweimer at redhat dot com
  2024-08-30  6:55 ` [Bug libc/32126] " fweimer at redhat dot com
  2024-08-30  8:20 ` sam at gentoo dot org
@ 2024-09-21 17:37 ` cvs-commit at gcc dot gnu.org
  2024-09-21 17:38 ` fweimer at redhat dot com
  3 siblings, 0 replies; 5+ messages in thread
From: cvs-commit at gcc dot gnu.org @ 2024-09-21 17:37 UTC (permalink / raw)
  To: glibc-bugs

https://sourceware.org/bugzilla/show_bug.cgi?id=32126

--- Comment #1 from Sourceware Commits <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Florian Weimer <fw@sourceware.org>:

https://sourceware.org/git/gitweb.cgi?p=glibc.git;h=6f3f6c506cdaf981a4374f1f12863b98ac7fea1a

commit 6f3f6c506cdaf981a4374f1f12863b98ac7fea1a
Author: Florian Weimer <fweimer@redhat.com>
Date:   Sat Sep 21 19:32:34 2024 +0200

    Linux: readdir64_r should not skip d_ino == 0 entries (bug 32126)

    This is the same bug as bug 12165, but for readdir_r.  The
    regression test covers both bug 12165 and bug 32126.

    Reviewed-by: DJ Delorie <dj@redhat.com>

-- 
You are receiving this mail because:
You are on the CC list for the bug.

^ permalink raw reply	[flat|nested] 5+ messages in thread

* [Bug libc/32126] readdir64_r: Do not skip entries with zero d_ino values
  2024-08-30  6:53 [Bug libc/32126] New: readdir64_r: Do not skip entries with zero d_ino values fweimer at redhat dot com
                   ` (2 preceding siblings ...)
  2024-09-21 17:37 ` cvs-commit at gcc dot gnu.org
@ 2024-09-21 17:38 ` fweimer at redhat dot com
  3 siblings, 0 replies; 5+ messages in thread
From: fweimer at redhat dot com @ 2024-09-21 17:38 UTC (permalink / raw)
  To: glibc-bugs

https://sourceware.org/bugzilla/show_bug.cgi?id=32126

Florian Weimer <fweimer at redhat dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|---                         |2.41
             Status|ASSIGNED                    |RESOLVED
         Resolution|---                         |FIXED

--- Comment #2 from Florian Weimer <fweimer at redhat dot com> ---
Fixed for 2.41.

-- 
You are receiving this mail because:
You are on the CC list for the bug.

^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2024-09-21 17:38 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-08-30  6:53 [Bug libc/32126] New: readdir64_r: Do not skip entries with zero d_ino values fweimer at redhat dot com
2024-08-30  6:55 ` [Bug libc/32126] " fweimer at redhat dot com
2024-08-30  8:20 ` sam at gentoo dot org
2024-09-21 17:37 ` cvs-commit at gcc dot gnu.org
2024-09-21 17:38 ` fweimer at redhat dot com

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).