From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 2851 invoked by alias); 23 Jun 2014 03:42:44 -0000 Mailing-List: contact glibc-bugs-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Post: List-Help: , Sender: glibc-bugs-owner@sourceware.org Received: (qmail 2796 invoked by uid 48); 23 Jun 2014 03:42:35 -0000 From: "allachan at au1 dot ibm.com" To: glibc-bugs@sourceware.org Subject: [Bug libc/4403] strfry() gives skewed distributions Date: Mon, 23 Jun 2014 03:42:00 -0000 X-Bugzilla-Reason: CC X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: glibc X-Bugzilla-Component: libc X-Bugzilla-Version: unspecified X-Bugzilla-Keywords: X-Bugzilla-Severity: normal X-Bugzilla-Who: allachan at au1 dot ibm.com X-Bugzilla-Status: REOPENED X-Bugzilla-Priority: P2 X-Bugzilla-Assigned-To: unassigned at sourceware dot org X-Bugzilla-Target-Milestone: --- X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: cc Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit X-Bugzilla-URL: http://sourceware.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-SW-Source: 2014-06/txt/msg01370.txt.bz2 https://sourceware.org/bugzilla/show_bug.cgi?id=4403 paxdiablo changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |allachan at au1 dot ibm.com --- Comment #10 from paxdiablo --- Well, nothing in the doco (http://www.gnu.org/software/libc/manual/html_node/strfry.html) for strfry() stated that all combinations would be equally likely. The only mention of uniform distribution was that it was used to do the swaps themselves, not that the results would be uniformly distributed. In any case, when I make stir fry, it's rarely distributed perfectly. Having said that, Ulrich probably spent more time complaining about the patch than it would have taken to just put the damn thing in :-) I have to go with Reuben here. If it's a joke, get rid of it, it has no place in a serious piece of software. If not, we should be willing to accept patches that make it better in some way, given any constraints from elsewhere (such as time needed by maintainers to do it). -- You are receiving this mail because: You are on the CC list for the bug.