public inbox for glibc-bugs@sourceware.org
help / color / mirror / Atom feed
* [Bug hurd/4822] grow_heap: static linking warns about madvise() not implemented
[not found] <bug-4822-131@http.sourceware.org/bugzilla/>
@ 2012-02-15 21:49 ` jsm28 at gcc dot gnu.org
2012-02-15 22:17 ` roland at gnu dot org
` (3 subsequent siblings)
4 siblings, 0 replies; 5+ messages in thread
From: jsm28 at gcc dot gnu.org @ 2012-02-15 21:49 UTC (permalink / raw)
To: glibc-bugs
http://sourceware.org/bugzilla/show_bug.cgi?id=4822
Joseph Myers <jsm28 at gcc dot gnu.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Component|ports |hurd
--- Comment #1 from Joseph Myers <jsm28 at gcc dot gnu.org> 2012-02-15 21:49:01 UTC ---
As I understand it this is an issue with glibc for Hurd, not for architectures
in ports.
--
Configure bugmail: http://sourceware.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
^ permalink raw reply [flat|nested] 5+ messages in thread
* [Bug hurd/4822] grow_heap: static linking warns about madvise() not implemented
[not found] <bug-4822-131@http.sourceware.org/bugzilla/>
2012-02-15 21:49 ` [Bug hurd/4822] grow_heap: static linking warns about madvise() not implemented jsm28 at gcc dot gnu.org
@ 2012-02-15 22:17 ` roland at gnu dot org
2012-02-16 13:01 ` joseph at codesourcery dot com
` (2 subsequent siblings)
4 siblings, 0 replies; 5+ messages in thread
From: roland at gnu dot org @ 2012-02-15 22:17 UTC (permalink / raw)
To: glibc-bugs
http://sourceware.org/bugzilla/show_bug.cgi?id=4822
Roland McGrath <roland at gnu dot org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |RESOLVED
Resolution| |FIXED
--- Comment #2 from Roland McGrath <roland at gnu dot org> 2012-02-15 22:16:29 UTC ---
Should be fixed in trunk, but I didn't actually try to compile for Hurd.
--
Configure bugmail: http://sourceware.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
^ permalink raw reply [flat|nested] 5+ messages in thread
* [Bug hurd/4822] grow_heap: static linking warns about madvise() not implemented
[not found] <bug-4822-131@http.sourceware.org/bugzilla/>
2012-02-15 21:49 ` [Bug hurd/4822] grow_heap: static linking warns about madvise() not implemented jsm28 at gcc dot gnu.org
2012-02-15 22:17 ` roland at gnu dot org
@ 2012-02-16 13:01 ` joseph at codesourcery dot com
2012-02-17 7:58 ` tschwinge at sourceware dot org
2021-02-23 10:19 ` samuel.thibault@ens-lyon.org
4 siblings, 0 replies; 5+ messages in thread
From: joseph at codesourcery dot com @ 2012-02-16 13:01 UTC (permalink / raw)
To: glibc-bugs
http://sourceware.org/bugzilla/show_bug.cgi?id=4822
--- Comment #3 from joseph at codesourcery dot com <joseph at codesourcery dot com> 2012-02-16 12:57:48 UTC ---
It appears to be current practice that the person committing a patch
fixing a (non-ports) bug should also add that bug to the list in the NEWS
file, so 4822 should be added there.
--
Configure bugmail: http://sourceware.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
^ permalink raw reply [flat|nested] 5+ messages in thread
* [Bug hurd/4822] grow_heap: static linking warns about madvise() not implemented
[not found] <bug-4822-131@http.sourceware.org/bugzilla/>
` (2 preceding siblings ...)
2012-02-16 13:01 ` joseph at codesourcery dot com
@ 2012-02-17 7:58 ` tschwinge at sourceware dot org
2021-02-23 10:19 ` samuel.thibault@ens-lyon.org
4 siblings, 0 replies; 5+ messages in thread
From: tschwinge at sourceware dot org @ 2012-02-17 7:58 UTC (permalink / raw)
To: glibc-bugs
http://sourceware.org/bugzilla/show_bug.cgi?id=4822
Thomas Schwinge <tschwinge at sourceware dot org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|RESOLVED |VERIFIED
CC| |tschwinge at sourceware dot
| |org
--- Comment #4 from Thomas Schwinge <tschwinge at sourceware dot org> 2012-02-17 07:57:12 UTC ---
(In reply to comment #2)
> Should be fixed in trunk, but I didn't actually try to compile for Hurd.
I fixed it up for you in commit 9078ce930afda8bbcba6fe860a13ca62abcf2742.
;-)
Errors and warnings were:
gcc-4.4 malloc.c [...]
[...]
In file included from ../include/sys/mman.h:2,
from malloc.c:1754:
../misc/sys/mman.h:95: error: expected identifier or '(' before 'void'
../misc/sys/mman.h:95: error: expected ')' before '(' token
[...]
make[3]: ***
[/media/erich/home/thomas/tmp/glibc/debian/madvise/eglibc-2.13/build-tree/hurd-i386-libc/malloc/malloc.o]
Error 1
make[3]: Leaving directory
`/media/erich/home/thomas/tmp/glibc/debian/madvise/eglibc-2.13/malloc'
make[2]: *** [malloc/subdir_lib] Error 2
(Poor GCC, seeing that ``prototype''.) After fixing that:
In file included from malloc.c:2567:
arena.c: In function 'shrink_heap':
arena.c:823: warning: left-hand operand of comma expression has no effect
arena.c:823: warning: left-hand operand of comma expression has no effect
malloc.c: In function 'mTRIm':
malloc.c:5874: warning: left-hand operand of comma expression has no effect
malloc.c:5874: warning: left-hand operand of comma expression has no effect
Now the situation is as follows:
$ echo 'int main() { }' | gcc -o /dev/null -x c -
$ echo 'int main() { madvise (); }' | gcc -o /dev/null -x c -
$ echo 'int main() { }' | gcc -o /dev/null -static -x c -
$ echo 'int main() { madvise (); }' | gcc -o /dev/null -static -x c -
/tmp/cce05X6t.o: In function `main':
:(.text+0x7): warning: warning: madvise is not implemented and will always
fail
That is, in the -static case, we only get the warning if madvise is
actively being used in the user code, but not due to glibc's own usage in
malloc.
Joseph already had amended the NEWS file.
Samuel, you can now replace the Debian glibc patch with
d2c736f809690dd69f1cade53a61b99e401bb0e3 and
9078ce930afda8bbcba6fe860a13ca62abcf2742.
--
Configure bugmail: http://sourceware.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
^ permalink raw reply [flat|nested] 5+ messages in thread
* [Bug hurd/4822] grow_heap: static linking warns about madvise() not implemented
[not found] <bug-4822-131@http.sourceware.org/bugzilla/>
` (3 preceding siblings ...)
2012-02-17 7:58 ` tschwinge at sourceware dot org
@ 2021-02-23 10:19 ` samuel.thibault@ens-lyon.org
4 siblings, 0 replies; 5+ messages in thread
From: samuel.thibault@ens-lyon.org @ 2021-02-23 10:19 UTC (permalink / raw)
To: glibc-bugs
https://sourceware.org/bugzilla/show_bug.cgi?id=4822
Samuel Thibault <samuel.thibault@ens-lyon.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Target Milestone|--- |2.16
--
You are receiving this mail because:
You are on the CC list for the bug.
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2021-02-23 10:19 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <bug-4822-131@http.sourceware.org/bugzilla/>
2012-02-15 21:49 ` [Bug hurd/4822] grow_heap: static linking warns about madvise() not implemented jsm28 at gcc dot gnu.org
2012-02-15 22:17 ` roland at gnu dot org
2012-02-16 13:01 ` joseph at codesourcery dot com
2012-02-17 7:58 ` tschwinge at sourceware dot org
2021-02-23 10:19 ` samuel.thibault@ens-lyon.org
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).