[Bug math/6803] scalb(), scalbln(), scalbn() do not set errno on overflow/underflow

[Bug math/6803] scalb(), scalbln(), scalbn() do not set errno on overflow/underflow

[jsm28 at gcc dot gnu.org]

http://sourceware.org/bugzilla/show_bug.cgi?id=6803

Joseph Myers <jsm28 at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         AssignedTo|aj at suse dot de           |unassigned at sourceware
                   |                            |dot org

--- Comment #5 from Joseph Myers <jsm28 at gcc dot gnu.org> 2012-03-01 17:34:28 UTC ---
Confirmed with current sources on x86 and x86_64.

-- 
Configure bugmail: http://sourceware.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

[Bug math/6803] scalb(), scalbln(), scalbn() do not set errno on overflow/underflow

[cvs-commit at gcc dot gnu.org]

https://sourceware.org/bugzilla/show_bug.cgi?id=6803

--- Comment #6 from cvs-commit at gcc dot gnu.org <cvs-commit at gcc dot gnu.org> ---
This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "GNU C Library master sources".

The branch, master has been updated
       via  8795b4a443a8f19d279e0c1bc99b73d1f5aec166 (commit)
      from  54fa2475d37b9c7afd903eb970362e50ec76f01e (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
https://sourceware.org/git/gitweb.cgi?p=glibc.git;h=8795b4a443a8f19d279e0c1bc99b73d1f5aec166

commit 8795b4a443a8f19d279e0c1bc99b73d1f5aec166
Author: Joseph Myers <joseph@codesourcery.com>
Date:   Mon Mar 31 14:57:53 2014 +0000

    Set errno for scalb errors (bug 6803, bug 6804).

    This patch fixes the default mode of scalb to set errno (bugs 6803 and
    6804).

    Previously, the _LIB_VERSION == _SVID_ mode would set errno but only
    in some relevant cases, and with various peculiarities (such as errno
    setting when an exact infinity or zero result arises with an argument
    to scalb being an infinity).  This patch leaves this mode
    bug-compatible, while making the default mode set errno in accordance
    with normal practice (so an exact infinity from an infinite argument
    is not an error, and nor is an exact zero result).  gen-libm-test.pl
    is taught new notation such as ERRNO_PLUS_OFLOW to facilitate writing
    the tests of errno setting for underflow / overflow in libm-test.inc.

    Note that bug 6803 also covers scalbn and scalbln, but this patch only
    addresses the scalb parts of that bug (along with the whole of bug
    6804).

    Tested x86_64 and x86.

        [BZ #6803]
        [BZ #6804]
        * math/w_scalb.c (__scalb): For non-SVID mode, check result and
        set errno as appropriate.
        * math/w_scalbf.c (__scalbf): Likewise.
        * math/w_scalbl.c (__scalbl): Likewise.
        * math/gen-libm-test.pl (parse_args): Handle ERRNO_PLUS_OFLOW,
        ERRNO_MINUS_OFLOW, ERRNO_PLUS_UFLOW and ERRNO_MINUS_UFLOW.
        * math/libm-test.inc (scalb_test_data): Add errno expectations.
        Add more NaN tests.

-----------------------------------------------------------------------

Summary of changes:
 ChangeLog             |   11 ++++
 NEWS                  |   10 ++--
 math/gen-libm-test.pl |   10 ++++
 math/libm-test.inc    |  134 +++++++++++++++++++++++++------------------------
 math/w_scalb.c        |   30 ++++++++++-
 math/w_scalbf.c       |   30 ++++++++++-
 math/w_scalbl.c       |   30 ++++++++++-
 7 files changed, 175 insertions(+), 80 deletions(-)

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug math/6803] scalb(), scalbln(), scalbn() do not set errno on overflow/underflow

[cvs-commit at gcc dot gnu.org]

https://sourceware.org/bugzilla/show_bug.cgi?id=6803

--- Comment #9 from cvs-commit at gcc dot gnu.org <cvs-commit at gcc dot gnu.org> ---
This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "GNU C Library master sources".

The branch, master has been updated
       via  da2f4f2dd5c07e1949f81a5ee23f880e891e3a82 (commit)
      from  bb95a72318e747ce8854e161cc590e67ac17f4f9 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
https://sourceware.org/git/gitweb.cgi?p=glibc.git;h=da2f4f2dd5c07e1949f81a5ee23f880e891e3a82

commit da2f4f2dd5c07e1949f81a5ee23f880e891e3a82
Author: Joseph Myers <joseph@codesourcery.com>
Date:   Wed Sep 16 21:11:00 2015 +0000

    Make scalbn set errno (bug 6803).

    As noted in bug 6803, scalbn fails to set errno on overflow and
    underflow.  This patch fixes this by making scalbn an alias of ldexp,
    which has exactly the same semantics (for floating-point types with
    radix 2) and already has wrappers that deal with setting errno,
    instead of an alias of the internal __scalbn (which ldexp calls).

    Notes:

    * Where compat symbols were defined for scalbn functions, I didn't
      change what they point to (to keep the patch minimal), so such
      compat symbols continue to go directly to the non-errno-setting
      functions.

    * Mike, I didn't do anything with the IA64 versions of these
      functions, where I think both the ldexp and scalbn functions already
      deal with setting errno.  As a cleanup (not needed to fix this bug)
      however you might want to make those functions into aliases for
      IA64; there is no need for them to be separate function
      implementations at all.

    * This concludes the fix for bug 6803 since the scalb and scalbln
      cases of that bug were fixed some time ago.

    Tested for x86_64, x86, mips64 and powerpc.

        [BZ #6803]
        * math/s_ldexp.c (scalbn): Define as weak alias of __ldexp.
        [NO_LONG_DOUBLE] (scalbnl): Define as weak alias of __ldexp.
        * math/s_ldexpf.c (scalbnf): Define as weak alias of __ldexpf.
        * math/s_ldexpl.c (scalbnl): Define as weak alias of __ldexpl.
        * sysdeps/i386/fpu/s_scalbn.S (scalbn): Remove alias.
        * sysdeps/i386/fpu/s_scalbnf.S (scalbnf): Likewise.
        * sysdeps/i386/fpu/s_scalbnl.S (scalbnl): Likewise.
        * sysdeps/ieee754/dbl-64/s_scalbn.c (scalbn): Likewise.
        [NO_LONG_DOUBLE] (scalbnl): Likewise.
        * sysdeps/ieee754/dbl-64/wordsize-64/s_scalbn.c (scalbn):
        Likewise.
        [NO_LONG_DOUBLE] (scalbnl): Likewise.
        * sysdeps/ieee754/flt-32/s_scalbnf.c (scalbnf): Likewise.
        * sysdeps/ieee754/ldbl-128/s_scalbnl.c (scalbnl): Likewise.
        * sysdeps/ieee754/ldbl-128ibm/s_scalbnl.c (scalbnl): Remove
        long_double_symbol calls.
        * sysdeps/ieee754/ldbl-64-128/s_scalbnl.c (scalbnl): Likewise.
        * sysdeps/ieee754/ldbl-opt/s_ldexpl.c (__ldexpl_2): Define as
        strong alias of __ldexpl.
        (scalbnl): Define using long_double_symbol.
        * sysdeps/m68k/m680x0/fpu/s_scalbn.c (__CONCATX(scalbn,suffix)):
        Remove alias.
        * sysdeps/sparc/sparc64/soft-fp/s_scalbnl.c (scalbnl): Likewise.
        * sysdeps/x86_64/fpu/s_scalbnl.S (scalbnl): Likewise.
        * math/libm-test.inc (scalbn_test_data): Add errno expectations.
        (scalbln_test_data): Add more errno expectations.

-----------------------------------------------------------------------

Summary of changes:
 ChangeLog                                     |   30 +++++
 NEWS                                          |   14 ++--
 math/libm-test.inc                            |  144 ++++++++++++------------
 math/s_ldexp.c                                |    2 +
 math/s_ldexpf.c                               |    1 +
 math/s_ldexpl.c                               |    1 +
 sysdeps/i386/fpu/s_scalbn.S                   |    1 -
 sysdeps/i386/fpu/s_scalbnf.S                  |    1 -
 sysdeps/i386/fpu/s_scalbnl.S                  |    1 -
 sysdeps/ieee754/dbl-64/s_scalbn.c             |    2 -
 sysdeps/ieee754/dbl-64/wordsize-64/s_scalbn.c |    2 -
 sysdeps/ieee754/flt-32/s_scalbnf.c            |    1 -
 sysdeps/ieee754/ldbl-128/s_scalbnl.c          |    1 -
 sysdeps/ieee754/ldbl-128ibm/s_scalbnl.c       |    5 -
 sysdeps/ieee754/ldbl-64-128/s_scalbnl.c       |    5 -
 sysdeps/ieee754/ldbl-opt/s_ldexpl.c           |    3 +
 sysdeps/m68k/m680x0/fpu/s_scalbn.c            |    1 -
 sysdeps/sparc/sparc64/soft-fp/s_scalbnl.c     |    2 -
 sysdeps/x86_64/fpu/s_scalbnl.S                |    1 -
 19 files changed, 116 insertions(+), 102 deletions(-)

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug math/6803] scalb(), scalbln(), scalbn() do not set errno on overflow/underflow

[jsm28 at gcc dot gnu.org]

https://sourceware.org/bugzilla/show_bug.cgi?id=6803

Joseph Myers <jsm28 at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |FIXED
   Target Milestone|---                         |2.23

--- Comment #10 from Joseph Myers <jsm28 at gcc dot gnu.org> ---
Fixed for 2.23.

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug math/6803] scalb(), scalbln(), scalbn() do not set errno on overflow/underflow

[mtk.manpages at gmail dot com]

https://sourceware.org/bugzilla/show_bug.cgi?id=6803

--- Comment #13 from Michael Kerrisk <mtk.manpages at gmail dot com> ---
Fix documented for man-pages-5.07

commit ab5c28f9423931435a1cf41a0b058459b2bce998 (HEAD -> master)
Author: Michael Kerrisk <mtk.manpages@gmail.com>
Date:   Sat May 23 12:20:59 2020 +0200

    scalb.3: These functions now correctly set errno for the EDOM and ERANGE
cas
es

    Modify DESCRIPTION appropriately and add BUGS section.
    The fix was in glibc 2.20.

    See https://www.sourceware.org/bugzilla/show_bug.cgi?id=6803
    and https://www.sourceware.org/bugzilla/show_bug.cgi?id=6804

    Signed-off-by: Michael Kerrisk <mtk.manpages@gmail.com>

diff --git a/man3/scalb.3 b/man3/scalb.3
index 2db0bd9ad..c685b68eb 100644
--- a/man3/scalb.3
+++ b/man3/scalb.3
@@ -150,34 +150,28 @@ The following errors can occur:
 Domain error: \fIx\fP is 0, and \fIexp\fP is positive infinity, \
 or \fIx\fP is positive infinity and \fIexp\fP is negative infinity \
 and the other argument is not a NaN
-.\" .I errno
-.\" is set to
-.\" .BR EDOM .
+.I errno
+is set to
+.BR EDOM .
 An invalid floating-point exception
 .RB ( FE_INVALID )
 is raised.
 .TP
 Range error, overflow
-.\" .I errno
-.\" is set to
-.\" .BR ERANGE .
+.I errno
+is set to
+.BR ERANGE .
 An overflow floating-point exception
 .RB ( FE_OVERFLOW )
 is raised.
 .TP
 Range error, underflow
-.\" .I errno
-.\" is set to
-.\" .BR ERANGE .
+.I errno
+is set to
+.BR ERANGE .
 An underflow floating-point exception
 .RB ( FE_UNDERFLOW )
 is raised.
-.PP
-These functions do not set
-.IR errno .
-.\" FIXME . Is it intentional that these functions do not set errno?
-.\" Bug raised: http://sources.redhat.com/bugzilla/show_bug.cgi?id=6803
-.\" Bug raised: http://sources.redhat.com/bugzilla/show_bug.cgi?id=6804
 .SH ATTRIBUTES
 For an explanation of the terms used in this section, see
 .BR attributes (7).
@@ -215,6 +209,13 @@ are unstandardized;
 is nevertheless present on several other systems
 .\" Looking at header files: scalbf() is present on the
 .\" BSDs, Tru64, HP-UX 11, Irix 6.5; scalbl() is on HP-UX 11 and Tru64.
+.SH BUGS
+Before glibc 2.20,
+.\" http://sources.redhat.com/bugzilla/show_bug.cgi?id=6803
+.\" http://sources.redhat.com/bugzilla/show_bug.cgi?id=6804
+these functions did not set
+.I errno
+for domain and range errors.
 .SH SEE ALSO
 .BR ldexp (3),
 .BR scalbln (3)

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug math/6803] scalb(), scalbln(), scalbn() do not set errno on overflow/underflow

[mtk.manpages at gmail dot com]

https://sourceware.org/bugzilla/show_bug.cgi?id=6803

--- Comment #14 from Michael Kerrisk <mtk.manpages at gmail dot com> ---
Added a similar patch for scalbln(3) manual page.

commit 5b08d967e889c7bc403387755d7e74afb265aa9b (HEAD -> master)
Author: Michael Kerrisk <mtk.manpages@gmail.com>
Date:   Tue May 26 11:19:03 2020 +0200

    scalbln.3: These functions now correctly set errno for the ERANGE case

    Modify DESCRIPTION appropriately and add BUGS section.
    The fix was in glibc 2.20.

    See https://www.sourceware.org/bugzilla/show_bug.cgi?id=6803

    Signed-off-by: Michael Kerrisk <mtk.manpages@gmail.com>

diff --git a/man3/scalbln.3 b/man3/scalbln.3
index 6c926dae5..7bf8d422b 100644
--- a/man3/scalbln.3
+++ b/man3/scalbln.3
@@ -139,17 +139,12 @@ An overflow floating-point exception
 is raised.
 .TP
 Range error, underflow
-.\" .I errno
-.\" is set to
-.\" .BR ERANGE .
+.I errno
+is set to
+.BR ERANGE .
 An underflow floating-point exception
 .RB ( FE_UNDERFLOW )
 is raised.
-.PP
-These functions do not set
-.IR errno .
-.\" FIXME . Is it intentional that these functions do not set errno?
-.\" Bug raised: http://sources.redhat.com/bugzilla/show_bug.cgi?id=6803
 .SH VERSIONS
 These functions first appeared in glibc in version 2.1.
 .SH ATTRIBUTES
@@ -188,6 +183,12 @@ equals 2 (which is usual), then
 .BR scalbn ()
 is equivalent to
 .BR ldexp (3).
+.SH BUGS
+Before glibc 2.20,
+.\" http://sources.redhat.com/bugzilla/show_bug.cgi?id=6803
+these functions did not set
+.I errno
+for range errors.
 .SH SEE ALSO
 .BR ldexp (3),
 .BR scalb (3)

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug math/6803] scalb(), scalbln(), scalbn() do not set errno on overflow/underflow

[mtk dot manpages at gmail dot com]

------- Additional Comments From mtk dot manpages at gmail dot com  2008-07-31 11:11 -------
Sample runs demonstrating the problem

$ /tmp/mt_scalb -- dbl_max 1000
errno == 0
fetestexcept() says:  FE_OVERFLOW FE_INEXACT
scalb(1.79769313486231571e+308,1.00000000000000000e+03)=inf
0 FE_OVERFLOW +inf

$ /tmp/mt_scalb -- dbl_min -1000
errno == 0
fetestexcept() says:  FE_UNDERFLOW FE_INEXACT
scalb(2.22507385850720138e-308,-1.00000000000000000e+03)=0.00000000000000000e+00
0 FE_UNDERFLOW +0

$ /tmp/mt_scalbln -- dbl_max 1000
errno == 0
fetestexcept() says:  FE_OVERFLOW FE_INEXACT
scalbln(1.79769313486231571e+308,1000)=inf
0 FE_OVERFLOW +inf

$ /tmp/mt_scalbln -- dbl_min -1000
errno == 0
fetestexcept() says:  FE_UNDERFLOW FE_INEXACT
scalbln(2.22507385850720138e-308,-1000)=0.00000000000000000e+00
0 FE_UNDERFLOW +0

$ /tmp/mt_scalbn -- dbl_max 1000
errno == 0
fetestexcept() says:  FE_OVERFLOW FE_INEXACT
scalbn(1.79769313486231571e+308,1000)=inf
0 FE_OVERFLOW +inf

$ /tmp/mt_scalbn -- dbl_min -1000
errno == 0
fetestexcept() says:  FE_UNDERFLOW FE_INEXACT
scalbn(2.22507385850720138e-308,-1000)=0.00000000000000000e+00
0 FE_UNDERFLOW +0



-- 


http://sourceware.org/bugzilla/show_bug.cgi?id=6803

------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.

[Bug math/6803] scalb(), scalbln(), scalbn() do not set errno on overflow/underflow

[mtk dot manpages at gmail dot com]

------- Additional Comments From mtk dot manpages at gmail dot com  2008-07-31 11:07 -------
Created an attachment (id=2869)
 --> (http://sourceware.org/bugzilla/attachment.cgi?id=2869&action=view)
test program


-- 


http://sourceware.org/bugzilla/show_bug.cgi?id=6803

------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.

[Bug math/6803] scalb(), scalbln(), scalbn() do not set errno on overflow/underflow

[mtk dot manpages at gmail dot com]

------- Additional Comments From mtk dot manpages at gmail dot com  2008-07-31 11:07 -------
Created an attachment (id=2868)
 --> (http://sourceware.org/bugzilla/attachment.cgi?id=2868&action=view)
test program


-- 


http://sourceware.org/bugzilla/show_bug.cgi?id=6803

------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.

[Bug math/6803] scalb(), scalbln(), scalbn() do not set errno on overflow/underflow

[mtk dot manpages at gmail dot com]

------- Additional Comments From mtk dot manpages at gmail dot com  2008-07-31 11:06 -------
Created an attachment (id=2867)
 --> (http://sourceware.org/bugzilla/attachment.cgi?id=2867&action=view)
test program


-- 


http://sourceware.org/bugzilla/show_bug.cgi?id=6803

------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.