From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from air.basealt.ru (air.basealt.ru [194.107.17.39]) by sourceware.org (Postfix) with ESMTPS id 6A1EB3858D32 for ; Mon, 29 Jan 2024 17:32:51 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 6A1EB3858D32 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=basealt.ru Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=basealt.ru ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 6A1EB3858D32 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=194.107.17.39 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1706549573; cv=none; b=h1jXnDJUfJglc9TAyZSaN1ps/lWMGBw1EWQg28EjqEZ8dn1Jqcc5p4jqixUAUAWScvRAqbvSG2J4695L97uTb/NsUKfx3EG25luuxTOeMFoBCocm0NBmAUCOWnmXvTELZRoZKACkhzXRmquCCxiWOSqsGh5lnek7nUcXLx7+qoQ= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1706549573; c=relaxed/simple; bh=5u+6d+8gBTU/00ALIQvzomKnTaVjwesAdq/wdCwc/YU=; h=Message-ID:Date:MIME-Version:Subject:To:From; b=sFeQQ0+eszTUmMsJP7TfRMtzaqB8Ejf4SmEgUw5XgUXppojGV8AxrXqmSfS8auBldVb2hgkH2Fzgk0Rl41EyLVTWMrKmoaYY2q6Qzu/CSh7miecqRz8mm3Mmi+xWg0BLH7fCPHNXGGw91Z/TqeuxcfcJ/AxYaGZPKLBAFkBPeLg= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by air.basealt.ru (Postfix, from userid 490) id 762672F2023C; Mon, 29 Jan 2024 17:32:50 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-Spam-Level: X-Spam-Status: No, score=-2.0 required=5.0 tests=BAYES_00,KAM_DMARC_STATUS,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 Received: from [192.168.88.248] (l37-195-46-144.novotelecom.ru [37.195.46.144]) by air.basealt.ru (Postfix) with ESMTPSA id 11D442F2022A; Mon, 29 Jan 2024 17:32:48 +0000 (UTC) Message-ID: Date: Tue, 30 Jan 2024 00:32:47 +0700 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: Upstream glibc has a bug in math/e_exp10l.c To: Adhemerval Zanella Netto , glibc-bugs@sourceware.org, Wilco Dijkstra References: <9849562b-3fee-4002-87c6-655beb973654@basealt.ru> Content-Language: en-US From: Ilya Kurdyukov In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit List-Id: On 1/30/24 00:16, Adhemerval Zanella Netto wrote: > On 29/01/24 07:38, Ilya Kurdyukov wrote: >> Wilco Dijkstra made a typo in this patch: >> >> Add libm_alias_finite for _finite symbols >> >> author    Wilco Dijkstra >>     Tue, 16 Jul 2019 15:17:22 +0000 (12:17 -0300) >> committer    Adhemerval Zanella >>     Fri, 3 Jan 2020 13:02:04 +0000 (10:02 -0300) >> >> https://sourceware.org/git/?p=glibc.git;a=commitdiff;h=220622dde5704c95a100c2792a280f18f3deba73 >> >> Here in math/e_exp10l.c, the name "exp10l" must be used, but this line is copied from math/e_exp10.c and not changed: >> >>   34 libm_alias_finite (__ieee754_exp10, __exp10) >> >> https://sourceware.org/git/?p=glibc.git;a=blob;f=math/e_exp10l.c;h=b33d6fea239ebc20caf8b2dec9b7d03909a0fc81;hb=220622dde5704c95a100c2792a280f18f3deba73#l34 > It is indeed wrong, although it is not used by any ABI which defines > a long double different than double. Either the sysdep version > (ieee754/ldbl-128ibm, ieee754/ldbl-128) or an arch specific one > (m68k, x86). It is used in patches for the e2karchitecture. > If/once an ABI uses this generic version, it would most likely > generic either an build error (due wrong aliases) or an ABI > issue. Maybe a better option would just to remove this file.