From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pj1-x1034.google.com (mail-pj1-x1034.google.com [IPv6:2607:f8b0:4864:20::1034]) by sourceware.org (Postfix) with ESMTPS id 56A143858D32 for ; Mon, 29 Jan 2024 17:16:57 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 56A143858D32 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=linaro.org ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 56A143858D32 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2607:f8b0:4864:20::1034 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1706548620; cv=none; b=kct+/xuHDcdrk2dEIreDnlryXpx1BgQd30GvHzFVC0tj3PWcBjYzL9600lNdx3AuGT3lL1FgKzQHptHxp9SH2aoexHqzq8q3syJRLrfcpQoHc7IrV5oPDjPfN40sxoXulcSaNnQiFX9TTGha9BHjyLTIQKeH1EPqX9nunW5kxqc= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1706548620; c=relaxed/simple; bh=F59M0FIcRikpUISBr9I57V4eVYuMZGMglpb+JaWO40U=; h=DKIM-Signature:Message-ID:Date:MIME-Version:Subject:To:From; b=jKSLvAvlrokCXyOB/bMUR2KXwR+j1OPBWCnkTQwN57r4ft3wpiFEOO+lHxmuUCzO0TMZZ86n71GZ/5ZOe9xL7xatpoAVvvdOSlMwx79N/uBpa4xqI2NHYmINGghmKis+G+iBdOIkD2HHeo6uaPJ3YrPfj48HcYEKFQjtJK3vj6A= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by mail-pj1-x1034.google.com with SMTP id 98e67ed59e1d1-29359a09b1bso1266272a91.2 for ; Mon, 29 Jan 2024 09:16:57 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1706548616; x=1707153416; darn=sourceware.org; h=content-transfer-encoding:in-reply-to:organization:from:references :to:content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=oWdz5UVEcj3zLi9s9M/or1qX46d1o1SPII9ZoOJfKx8=; b=xlE/APb3kcBgUour7Ph8kze3dlFyW2JbL4HHvgT1DyI0X4mM9BNjGa8vRxzDqq8W6r 8JPKSKUYmRFvnktBdaC6rribfODnnnSmEQMTCQ+f7N20DiDjDZ4207KqQ54LvOkvrvV1 MHDLL2ILoXSOqfxvXNVXSu4JWaeCRoGHTunNKaYYWkbYKusM/3ZDRwrJaq1VHXjsy2nJ 4kIyDPzwsrhIzeFb5R8dPOaiqQrUCrD38+v+acqj33uKqJUNlujdyd8qkeAmNLwRkbnf tVNZ/SGPHp7jRFVMHQT4TFTb7D6/C2sP1UYA2juhnoGaVfMwnJfPBI/QDUqqiX3t/6P1 AN9Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1706548616; x=1707153416; h=content-transfer-encoding:in-reply-to:organization:from:references :to:content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=oWdz5UVEcj3zLi9s9M/or1qX46d1o1SPII9ZoOJfKx8=; b=PvayIHa2V2IIgKAE3qHej8u2DL/+4GRY9AMmoLYP2Yd4oUZtBMaHvM8Dcp5oXJm2lW +uVdIt5orxZBGRl/OywssNntlqkBAOJkZa3xF0qRRTi9cURxfuphWvCZH6rsRXdFBOEX MBlwcQyXOs0nGtsuYbN/FQJqyPiFi4LjaIc6nj0OjFjzUEdGREgtfEQSWrgqhAOSxO4T aqsvbiDWferKON+MC6/O4ORkM7iVIzip3+FjRlf5qVJEDhnmSXNJsoz9KLK2eQpIQzZy KYpNH+J9TgmAES4GsEq87Ol0hN3/4rBuAkLE1HxWnx2rfynbYQzsq4DzPhwR+8X1VMHg IXQg== X-Gm-Message-State: AOJu0YzUL+bUSnvXtnKdazXQ+W9QiXsLGZQok/NkUPu2hswIMvqwYVJ2 hKKi93VGzd+GQ2VESIrMWCDxn6xch8svo9BeGgLsSc1hN2ScjwXWFwuAoLsGxqBJwqDqM/O08c3 Z X-Google-Smtp-Source: AGHT+IHtMRJcYsPn/NjD/NrI8SQFMEtqGyacPHUkrtoQ6HJOGfHNsoKhc4JadwnWGbiRNB0+m165Jg== X-Received: by 2002:a17:90a:df81:b0:28f:fc47:e797 with SMTP id p1-20020a17090adf8100b0028ffc47e797mr2474731pjv.7.1706548616275; Mon, 29 Jan 2024 09:16:56 -0800 (PST) Received: from ?IPV6:2804:1b3:a7c3:574b:21d1:1aa1:576f:ec68? ([2804:1b3:a7c3:574b:21d1:1aa1:576f:ec68]) by smtp.gmail.com with ESMTPSA id t3-20020a17090a950300b00290a26531f5sm8639291pjo.7.2024.01.29.09.16.54 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 29 Jan 2024 09:16:55 -0800 (PST) Message-ID: Date: Mon, 29 Jan 2024 14:16:53 -0300 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: Upstream glibc has a bug in math/e_exp10l.c Content-Language: en-US To: Ilya Kurdyukov , glibc-bugs@sourceware.org, Wilco Dijkstra References: <9849562b-3fee-4002-87c6-655beb973654@basealt.ru> From: Adhemerval Zanella Netto Organization: Linaro In-Reply-To: <9849562b-3fee-4002-87c6-655beb973654@basealt.ru> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-6.0 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 29/01/24 07:38, Ilya Kurdyukov wrote: > Wilco Dijkstra made a typo in this patch: > > Add libm_alias_finite for _finite symbols > > author    Wilco Dijkstra >     Tue, 16 Jul 2019 15:17:22 +0000 (12:17 -0300) > committer    Adhemerval Zanella >     Fri, 3 Jan 2020 13:02:04 +0000 (10:02 -0300) > > https://sourceware.org/git/?p=glibc.git;a=commitdiff;h=220622dde5704c95a100c2792a280f18f3deba73 > > Here in math/e_exp10l.c, the name "exp10l" must be used, but this line is copied from math/e_exp10.c and not changed: > >   34 libm_alias_finite (__ieee754_exp10, __exp10) > > https://sourceware.org/git/?p=glibc.git;a=blob;f=math/e_exp10l.c;h=b33d6fea239ebc20caf8b2dec9b7d03909a0fc81;hb=220622dde5704c95a100c2792a280f18f3deba73#l34 It is indeed wrong, although it is not used by any ABI which defines a long double different than double. Either the sysdep version (ieee754/ldbl-128ibm, ieee754/ldbl-128) or an arch specific one (m68k, x86). If/once an ABI uses this generic version, it would most likely generic either an build error (due wrong aliases) or an ABI issue. Maybe a better option would just to remove this file.