public inbox for glibc-cvs@sourceware.org
help / color / mirror / Atom feed
From: Joseph Myers <jsm28@sourceware.org>
To: glibc-cvs@sourceware.org
Subject: [glibc] Allow memset local PLT reference for powerpc soft-float.
Date: Thu, 13 Jun 2019 12:22:00 -0000	[thread overview]
Message-ID: <20190613122208.7577.qmail@sourceware.org> (raw)

https://sourceware.org/git/gitweb.cgi?p=glibc.git;h=a26e2e9feab87d4f745c31411458b048742ac733

commit a26e2e9feab87d4f745c31411458b048742ac733
Author: Joseph Myers <joseph@codesourcery.com>
Date:   Thu Jun 13 12:21:50 2019 +0000

    Allow memset local PLT reference for powerpc soft-float.
    
    Some recent change on GCC mainline resulted in the localplt test
    failing for powerpc soft-float (not sure exactly when, as the failure
    appeared when there were other build test failures as well;
    <https://sourceware.org/ml/libc-testresults/2019-q2/msg00261.html>
    shows it remaining when other failures went away).  The problem is a
    call to memset that GCC now generates in the libgcc long double code.
    
    Since memset is documented as a function GCC may always implicitly
    generate calls to, it seems reasonable to allow that local PLT
    reference (just like those for libgcc functions that GCC implicitly
    generates calls to and that are also exported from libc.so), which
    this patch does.
    
    Tested for powerpc soft-float with build-many-glibcs.py.
    
    	* sysdeps/unix/sysv/linux/powerpc/powerpc32/nofpu/localplt.data:
    	Allow memset in libc.so.

Diff:
---
 ChangeLog                                                     | 5 +++++
 sysdeps/unix/sysv/linux/powerpc/powerpc32/nofpu/localplt.data | 1 +
 2 files changed, 6 insertions(+)

diff --git a/ChangeLog b/ChangeLog
index 7cc8f6e..8f10f64 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,8 @@
+2019-06-13  Joseph Myers  <joseph@codesourcery.com>
+
+	* sysdeps/unix/sysv/linux/powerpc/powerpc32/nofpu/localplt.data:
+	Allow memset in libc.so.
+
 2019-06-13  Szabolcs Nagy  <szabolcs.nagy@arm.com>
 
 	* sysdeps/aarch64/dl-dtprocnum.h: New file.
diff --git a/sysdeps/unix/sysv/linux/powerpc/powerpc32/nofpu/localplt.data b/sysdeps/unix/sysv/linux/powerpc/powerpc32/nofpu/localplt.data
index fead931..647e735 100644
--- a/sysdeps/unix/sysv/linux/powerpc/powerpc32/nofpu/localplt.data
+++ b/sysdeps/unix/sysv/linux/powerpc/powerpc32/nofpu/localplt.data
@@ -31,6 +31,7 @@ libc.so: calloc
 libc.so: free
 libc.so: malloc
 libc.so: memalign
+libc.so: memset ?
 libc.so: realloc
 libm.so: copysignl ?
 libm.so: fabsl


                 reply	other threads:[~2019-06-13 12:22 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190613122208.7577.qmail@sourceware.org \
    --to=jsm28@sourceware.org \
    --cc=glibc-cvs@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).