From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 7623 invoked by alias); 13 Jun 2019 12:22:08 -0000 Mailing-List: contact glibc-cvs-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: , Sender: glibc-cvs-owner@sourceware.org List-Subscribe: Received: (qmail 7578 invoked by uid 9119); 13 Jun 2019 12:22:08 -0000 Date: Thu, 13 Jun 2019 12:22:00 -0000 Message-ID: <20190613122208.7577.qmail@sourceware.org> Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit From: Joseph Myers To: glibc-cvs@sourceware.org Subject: [glibc] Allow memset local PLT reference for powerpc soft-float. X-Act-Checkin: glibc X-Git-Author: Joseph Myers X-Git-Refname: refs/heads/master X-Git-Oldrev: 82bc69c012838a381c4167c156a06f4598f34227 X-Git-Newrev: a26e2e9feab87d4f745c31411458b048742ac733 X-SW-Source: 2019-q2/txt/msg00319.txt.bz2 https://sourceware.org/git/gitweb.cgi?p=glibc.git;h=a26e2e9feab87d4f745c31411458b048742ac733 commit a26e2e9feab87d4f745c31411458b048742ac733 Author: Joseph Myers Date: Thu Jun 13 12:21:50 2019 +0000 Allow memset local PLT reference for powerpc soft-float. Some recent change on GCC mainline resulted in the localplt test failing for powerpc soft-float (not sure exactly when, as the failure appeared when there were other build test failures as well; shows it remaining when other failures went away). The problem is a call to memset that GCC now generates in the libgcc long double code. Since memset is documented as a function GCC may always implicitly generate calls to, it seems reasonable to allow that local PLT reference (just like those for libgcc functions that GCC implicitly generates calls to and that are also exported from libc.so), which this patch does. Tested for powerpc soft-float with build-many-glibcs.py. * sysdeps/unix/sysv/linux/powerpc/powerpc32/nofpu/localplt.data: Allow memset in libc.so. Diff: --- ChangeLog | 5 +++++ sysdeps/unix/sysv/linux/powerpc/powerpc32/nofpu/localplt.data | 1 + 2 files changed, 6 insertions(+) diff --git a/ChangeLog b/ChangeLog index 7cc8f6e..8f10f64 100644 --- a/ChangeLog +++ b/ChangeLog @@ -1,3 +1,8 @@ +2019-06-13 Joseph Myers + + * sysdeps/unix/sysv/linux/powerpc/powerpc32/nofpu/localplt.data: + Allow memset in libc.so. + 2019-06-13 Szabolcs Nagy * sysdeps/aarch64/dl-dtprocnum.h: New file. diff --git a/sysdeps/unix/sysv/linux/powerpc/powerpc32/nofpu/localplt.data b/sysdeps/unix/sysv/linux/powerpc/powerpc32/nofpu/localplt.data index fead931..647e735 100644 --- a/sysdeps/unix/sysv/linux/powerpc/powerpc32/nofpu/localplt.data +++ b/sysdeps/unix/sysv/linux/powerpc/powerpc32/nofpu/localplt.data @@ -31,6 +31,7 @@ libc.so: calloc libc.so: free libc.so: malloc libc.so: memalign +libc.so: memset ? libc.so: realloc libm.so: copysignl ? libm.so: fabsl