public inbox for glibc-cvs@sourceware.org help / color / mirror / Atom feed
From: Tulio Magno Quites Machado Filho <tuliom@sourceware.org> To: glibc-cvs@sourceware.org Subject: [glibc] test-container: Install with $(all-subdirs) [BZ #24794] Date: Tue, 23 Jul 2019 16:29:00 -0000 [thread overview] Message-ID: <20190723162929.120508.qmail@sourceware.org> (raw) https://sourceware.org/git/gitweb.cgi?p=glibc.git;h=35e038c1d2ccb3a75395662f9c4f28d85a61444f commit 35e038c1d2ccb3a75395662f9c4f28d85a61444f Author: Tulio Magno Quites Machado Filho <tuliom@linux.ibm.com> Date: Mon Jul 22 17:34:13 2019 -0300 test-container: Install with $(all-subdirs) [BZ #24794] Whenever a sub-make is created, it inherits the variable subdirs from its parent. This is also true when make check is called with a restricted list of subdirs. In this scenario, make install is executed "partially" and testroot.pristine ends up with an incomplete installation. [BZ #24794] * Makefile (testroot.pristine/install.stamp): Pass subdirs='$(all-subdirs)' to make install. Reviewed-by: DJ Delorie <dj@redhat.com> Diff: --- ChangeLog | 4 ++++ Makefile | 3 ++- 2 files changed, 6 insertions(+), 1 deletion(-) diff --git a/ChangeLog b/ChangeLog index 8d4c898..78c3c61 100644 --- a/ChangeLog +++ b/ChangeLog @@ -1,5 +1,9 @@ 2019-07-23 Tulio Magno Quites Machado Filho <tuliom@linux.ibm.com> + [BZ #24794] + * Makefile (testroot.pristine/install.stamp): Pass + subdirs='$(all-subdirs)' to make install. + * Makefile (testroot.pristine/install.stamp): Execute ld.so with the same arguments used in all tests. diff --git a/Makefile b/Makefile index a4ed747..9fbf705 100644 --- a/Makefile +++ b/Makefile @@ -401,7 +401,8 @@ ifeq ($(run-built-tests),yes) $(test-wrapper) cp $$dso $(objpfx)testroot.pristine$$dso ;\ done endif - $(MAKE) install DESTDIR=$(objpfx)testroot.pristine + $(MAKE) install DESTDIR=$(objpfx)testroot.pristine \ + subdirs='$(all-subdirs)' touch $(objpfx)testroot.pristine/install.stamp tests-special-notdir = $(patsubst $(objpfx)%, %, $(tests-special))
reply other threads:[~2019-07-23 16:29 UTC|newest] Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20190723162929.120508.qmail@sourceware.org \ --to=tuliom@sourceware.org \ --cc=glibc-cvs@sourceware.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).