From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 71835 invoked by alias); 30 Jul 2019 14:05:38 -0000 Mailing-List: contact glibc-cvs-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: , Sender: glibc-cvs-owner@sourceware.org List-Subscribe: Received: (qmail 71760 invoked by uid 9119); 30 Jul 2019 14:05:37 -0000 Date: Tue, 30 Jul 2019 14:05:00 -0000 Message-ID: <20190730140537.71759.qmail@sourceware.org> Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit From: Joseph Myers To: glibc-cvs@sourceware.org Subject: [glibc] Restore r31 setting in powerpc32 swapcontext. X-Act-Checkin: glibc X-Git-Author: Joseph Myers X-Git-Refname: refs/heads/master X-Git-Oldrev: 8a814e20d443adc460a1030fa1a66aa9ae817483 X-Git-Newrev: c86b8e7579ac2c4a1f1f70a56715580ed77b4a79 X-SW-Source: 2019-q3/txt/msg00134.txt.bz2 https://sourceware.org/git/gitweb.cgi?p=glibc.git;h=c86b8e7579ac2c4a1f1f70a56715580ed77b4a79 commit c86b8e7579ac2c4a1f1f70a56715580ed77b4a79 Author: Joseph Myers Date: Tue Jul 30 14:05:11 2019 +0000 Restore r31 setting in powerpc32 swapcontext. Commit ffe8a9a8318e1db225b22da8bc067408494bac5c, "powerpc: Remove rt_sigreturn usage on context function", removed from powerpc32 swapcontext a setting of r31 that is relied upon in subsequent code. I'm not sure why this didn't produce test failures in Adhemerval's 32-bit testing; in my (soft-float) testing in preparation for 2.30 release, I see several context-related failures FAIL: stdlib/tst-makecontext2 FAIL: stdlib/tst-makecontext3 FAIL: stdlib/tst-setcontext FAIL: stdlib/tst-setcontext2 FAIL: stdlib/tst-setcontext4 FAIL: stdlib/tst-setcontext7 FAIL: stdlib/tst-setcontext9 FAIL: stdlib/tst-swapcontext1 that did not appear in 2.29 testing. This patch restores the removed register setting in question, and thus fixes those failures. Tested for powerpc (soft-float). * sysdeps/unix/sysv/linux/powerpc/powerpc32/swapcontext-common.S (__CONTEXT_FUNC_NAME): Restore setting of r31. Diff: --- ChangeLog | 5 +++++ sysdeps/unix/sysv/linux/powerpc/powerpc32/swapcontext-common.S | 3 +++ 2 files changed, 8 insertions(+) diff --git a/ChangeLog b/ChangeLog index a538454..6b46bfa 100644 --- a/ChangeLog +++ b/ChangeLog @@ -1,3 +1,8 @@ +2019-07-30 Joseph Myers + + * sysdeps/unix/sysv/linux/powerpc/powerpc32/swapcontext-common.S + (__CONTEXT_FUNC_NAME): Restore setting of r31. + 2019-07-30 Florian Weimer * nptl/tst-pthread-getattr.c (allocate_and_test): Change return diff --git a/sysdeps/unix/sysv/linux/powerpc/powerpc32/swapcontext-common.S b/sysdeps/unix/sysv/linux/powerpc/powerpc32/swapcontext-common.S index efebb10..6fa1ab7 100644 --- a/sysdeps/unix/sysv/linux/powerpc/powerpc32/swapcontext-common.S +++ b/sysdeps/unix/sysv/linux/powerpc/powerpc32/swapcontext-common.S @@ -276,6 +276,9 @@ ENTRY(__CONTEXT_FUNC_NAME) cmpwi r3,0 bne 3f /* L(error_exit) */ + lwz r4,_FRAME_PARM_SAVE2(r1) + lwz r31,_UC_REGS_PTR(r4) + #ifdef __CONTEXT_ENABLE_FPRS # ifdef __CONTEXT_ENABLE_VRS