public inbox for glibc-cvs@sourceware.org
help / color / mirror / Atom feed
* [glibc] linux: Make profil_counter a compat_symbol (BZ#17726)
@ 2019-08-23 14:45 Adhemerval Zanella
  0 siblings, 0 replies; only message in thread
From: Adhemerval Zanella @ 2019-08-23 14:45 UTC (permalink / raw)
  To: glibc-cvs

https://sourceware.org/git/gitweb.cgi?p=glibc.git;h=08d57105bbcbb4f950cd7cdf881a50977e44b8c6

commit 08d57105bbcbb4f950cd7cdf881a50977e44b8c6
Author: Adhemerval Zanella <adhemerval.zanella@linaro.org>
Date:   Thu Aug 1 18:01:22 2019 +0000

    linux: Make profil_counter a compat_symbol (BZ#17726)
    
    As indicated by Joseph's comment on BZ#17726, this symbol is most
    likely a historical ABI accident.  This patch make it on both arm
    and sparc ABIs a compat_symbol.
    
    Checked against a build arm-linux-gnueabihf, sparcv9-linux-gnu, adn
    sparc64-linux-gnu to see if the symbol is still present.
    
    	* gmon/Versions (libc) [GLIBC_2.31]: New entry.
    	* sysdeps/unix/sysv/linux/arm/profil-counter.h (profil_counter):
    	Make a compat_symbol.
    	* sysdeps/unix/sysv/linux/sparc/profil-counter.h
    	(__profil_counter_global): Likewise.

Diff:
---
 ChangeLog                                      | 6 ++++++
 gmon/Versions                                  | 2 ++
 sysdeps/unix/sysv/linux/arm/profil-counter.h   | 5 ++++-
 sysdeps/unix/sysv/linux/sparc/profil-counter.h | 5 ++++-
 4 files changed, 16 insertions(+), 2 deletions(-)

diff --git a/ChangeLog b/ChangeLog
index 386e025..8c98317 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,6 +1,12 @@
 2019-08-23  Adhemerval Zanella  <adhemerval.zanella@linaro.org>
 	    Florian Weimer  <fweimer@redhat.com>
 
+	* gmon/Versions (libc) [GLIBC_2.31]: New entry.
+	* sysdeps/unix/sysv/linux/arm/profil-counter.h (profil_counter):
+	Make a compat_symbol.
+	* sysdeps/unix/sysv/linux/sparc/profil-counter.h
+	(__profil_counter_global): Likewise.
+
 	* debug/segfault.c (install_handler): Use SA_SIGINFO if defined.
 	* sysdeps/generic/profil-counter.h (__profil_counter): Cast to
 	uintptr_t.
diff --git a/gmon/Versions b/gmon/Versions
index d0b6333..cc705bd 100644
--- a/gmon/Versions
+++ b/gmon/Versions
@@ -19,4 +19,6 @@ libc {
   GLIBC_2.2.3 {
     sprofil;
   }
+  GLIBC_2.31 {
+  }
 }
diff --git a/sysdeps/unix/sysv/linux/arm/profil-counter.h b/sysdeps/unix/sysv/linux/arm/profil-counter.h
index 040c7aa..df39333 100644
--- a/sysdeps/unix/sysv/linux/arm/profil-counter.h
+++ b/sysdeps/unix/sysv/linux/arm/profil-counter.h
@@ -30,5 +30,8 @@ __profil_counter (int signo, siginfo_t *_si, void *scp)
   asm volatile ("");
 }
 #ifndef __profil_counter
-weak_alias (__profil_counter, profil_counter)
+# include <shlib-compat.h>
+# if SHLIB_COMPAT (libc, GLIBC_2_0, GLIBC_2_31)
+compat_symbol (libc, __profil_counter, profil_counter, GLIBC_2_0);
+# endif
 #endif
diff --git a/sysdeps/unix/sysv/linux/sparc/profil-counter.h b/sysdeps/unix/sysv/linux/sparc/profil-counter.h
index ad06a4f..0127110 100644
--- a/sysdeps/unix/sysv/linux/sparc/profil-counter.h
+++ b/sysdeps/unix/sysv/linux/sparc/profil-counter.h
@@ -21,6 +21,8 @@
 #include <sysdeps/unix/sysv/linux/profil-counter.h>
 
 #ifndef __profil_counter
+# include <shlib-compat.h>
+# if SHLIB_COMPAT (libc, GLIBC_2_0, GLIBC_2_31)
 void
 __profil_counter_global (int signo, struct sigcontext *si)
 {
@@ -30,5 +32,6 @@ __profil_counter_global (int signo, struct sigcontext *si)
   profil_count (si->si_regs.pc);
 #endif
 }
-weak_alias (__profil_counter_global, profil_counter)
+compat_symbol (libc, __profil_counter_global, profil_counter, GLIBC_2_0);
+# endif
 #endif


^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2019-08-23 14:45 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-08-23 14:45 [glibc] linux: Make profil_counter a compat_symbol (BZ#17726) Adhemerval Zanella

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).