public inbox for glibc-cvs@sourceware.org help / color / mirror / Atom feed
From: Stefan Liebler <stli@sourceware.org> To: glibc-cvs@sourceware.org Subject: [glibc] S390: Fp comparison are now raising FE_INVALID with gcc 10. Date: Wed, 06 Nov 2019 07:08:00 -0000 [thread overview] Message-ID: <20191106070828.31432.qmail@sourceware.org> (raw) https://sourceware.org/git/gitweb.cgi?p=glibc.git;h=64bca76f42a82e6a9ea2b0166deab7aa2b7efbea commit 64bca76f42a82e6a9ea2b0166deab7aa2b7efbea Author: Stefan Liebler <stli@linux.ibm.com> Date: Wed Nov 6 08:07:40 2019 +0100 S390: Fp comparison are now raising FE_INVALID with gcc 10. The s390 gcc bug https://gcc.gnu.org/bugzilla/show_bug.cgi?id=77918 "S390: Floating point comparisons don't raise invalid for unordered operands." is fixed with gcc 10. Thus we conditionally set FIX_COMPARE_INVALID to 0 or 1. Diff: --- sysdeps/s390/fpu/fix-fp-int-compare-invalid.h | 12 +++++++----- 1 file changed, 7 insertions(+), 5 deletions(-) diff --git a/sysdeps/s390/fpu/fix-fp-int-compare-invalid.h b/sysdeps/s390/fpu/fix-fp-int-compare-invalid.h index dc2450c..440b3d0 100644 --- a/sysdeps/s390/fpu/fix-fp-int-compare-invalid.h +++ b/sysdeps/s390/fpu/fix-fp-int-compare-invalid.h @@ -27,10 +27,12 @@ <https://gcc.gnu.org/bugzilla/show_bug.cgi?id=77918>. There exists an equivalent gcc bugzilla for Intel: <https://gcc.gnu.org/bugzilla/show_bug.cgi?id=52451>. - Once the s390 gcc bug is fixed, the definition of FIX_COMPARE_INVALID - should have a __GNUC_PREREQ conditional added so that e.g. the workaround - to call feraiseexcept (FE_INVALID) in math/s_iseqsig_template.c can be - avoided. */ -#define FIX_COMPARE_INVALID 1 + This s390 gcc bug is fixed with gcc 10, thus we don't need the workaround + to call feraiseexcept (FE_INVALID) in math/s_iseqsig_template.c. */ +#if __GNUC_PREREQ (10, 0) +# define FIX_COMPARE_INVALID 0 +#else +# define FIX_COMPARE_INVALID 1 +#endif #endif /* fix-fp-int-compare-invalid.h */
reply other threads:[~2019-11-06 7:08 UTC|newest] Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20191106070828.31432.qmail@sourceware.org \ --to=stli@sourceware.org \ --cc=glibc-cvs@sourceware.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).