From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 83956 invoked by alias); 3 Dec 2019 17:04:07 -0000 Mailing-List: contact glibc-cvs-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: , Sender: glibc-cvs-owner@sourceware.org List-Subscribe: Received: (qmail 83922 invoked by uid 10126); 3 Dec 2019 17:04:07 -0000 Date: Tue, 03 Dec 2019 17:04:00 -0000 Message-ID: <20191203170407.83921.qmail@sourceware.org> Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit From: Gabriel F.T.Gomes To: glibc-cvs@sourceware.org Subject: [glibc/gabriel/powerpc-ieee128-printscan] Avoid compat symbols for totalorder in powerpc64le IEEE long double X-Act-Checkin: glibc X-Git-Author: Gabriel F. T. Gomes X-Git-Refname: refs/heads/gabriel/powerpc-ieee128-printscan X-Git-Oldrev: 675a15ed1e980c8473d843ae1de0e2d0be8e53b3 X-Git-Newrev: 9dcbdd544768e71ce2b0a8e127f6095d24ce8d15 X-SW-Source: 2019-q4/txt/msg00522.txt.bz2 https://sourceware.org/git/gitweb.cgi?p=glibc.git;h=9dcbdd544768e71ce2b0a8e127f6095d24ce8d15 commit 9dcbdd544768e71ce2b0a8e127f6095d24ce8d15 Author: Gabriel F. T. Gomes Date: Mon Sep 9 12:59:46 2019 -0500 Avoid compat symbols for totalorder in powerpc64le IEEE long double No changes since v2. Changes since v1: - Added comment on the redefinition of libm_alias_float128_other_r_ldbl. -- 8< -- On powerpc64le, the libm_alias_float128_other_r_ldbl macro is used to create an alias between totalorderf128 and __totalorderlieee128, as well as between the totalordermagf128 and __totalordermaglieee128. However, the totalorder* and totalordermag* functions changed their parameter type since commit ID 42760d764649 and got compat symbols for their old versions. With this change, the aforementioned macro would create two conflicting aliases for __totalorderlieee128 and __totalordermaglieee128. This patch avoids the creation of the alias between the IEEE long double symbols (__totalorderl*ieee128) and the compat symbols, because the IEEE long double functions have never been exported thus don't need such compat symbol. Tested for powerpc64le. Reviewed-by: Joseph Myers Diff: --- sysdeps/ieee754/ldbl-128/s_totalorderl.c | 9 +++++++++ sysdeps/ieee754/ldbl-128/s_totalordermagl.c | 9 +++++++++ 2 files changed, 18 insertions(+) diff --git a/sysdeps/ieee754/ldbl-128/s_totalorderl.c b/sysdeps/ieee754/ldbl-128/s_totalorderl.c index 098bd2b..f9db06c 100644 --- a/sysdeps/ieee754/ldbl-128/s_totalorderl.c +++ b/sysdeps/ieee754/ldbl-128/s_totalorderl.c @@ -74,6 +74,15 @@ __totalorder_compatl (_Float128 x, _Float128 y) { return __totalorderl (&x, &y); } +/* On platforms that reuse the _Float128 implementation for IEEE long + double (powerpc64le), the libm_alias_float128_other_r_ldbl macro + (which is called by the libm_alias_ldouble macro) is used to create + aliases between *f128 (_Float128 API) and __*ieee128 functions. + However, this compat version of totalorderl is older than the + availability of __ieee*128 symbols, thus, the compat alias is not + required, nor desired. */ +#undef libm_alias_float128_other_r_ldbl +#define libm_alias_float128_other_r_ldbl(from, to, r) #undef do_symbol #define do_symbol(orig_name, name, aliasname) \ strong_alias (orig_name, name) \ diff --git a/sysdeps/ieee754/ldbl-128/s_totalordermagl.c b/sysdeps/ieee754/ldbl-128/s_totalordermagl.c index b31788c..45b17ed 100644 --- a/sysdeps/ieee754/ldbl-128/s_totalordermagl.c +++ b/sysdeps/ieee754/ldbl-128/s_totalordermagl.c @@ -68,6 +68,15 @@ __totalordermag_compatl (_Float128 x, _Float128 y) { return __totalordermagl (&x, &y); } +/* On platforms that reuse the _Float128 implementation for IEEE long + double (powerpc64le), the libm_alias_float128_other_r_ldbl macro + (which is called by the libm_alias_ldouble macro) is used to create + aliases between *f128 (_Float128 API) and __*ieee128 functions. + However, this compat version of totalordermagl is older than the + availability of __ieee*128 symbols, thus, the compat alias is not + required, nor desired. */ +#undef libm_alias_float128_other_r_ldbl +#define libm_alias_float128_other_r_ldbl(from, to, r) #undef do_symbol #define do_symbol(orig_name, name, aliasname) \ strong_alias (orig_name, name) \