From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 97700 invoked by alias); 4 Dec 2019 17:01:48 -0000 Mailing-List: contact glibc-cvs-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: , Sender: glibc-cvs-owner@sourceware.org List-Subscribe: Received: (qmail 97648 invoked by uid 10126); 4 Dec 2019 17:01:47 -0000 Date: Wed, 04 Dec 2019 17:01:00 -0000 Message-ID: <20191204170147.97647.qmail@sourceware.org> Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit From: Gabriel F.T.Gomes To: glibc-cvs@sourceware.org Subject: [glibc] Do not use ld.so to open statically linked programs in debugglibc.sh X-Act-Checkin: glibc X-Git-Author: Gabriel F. T. Gomes X-Git-Refname: refs/heads/master X-Git-Oldrev: 6ef1bab699eb82ad24d52a4a045bceb4f7533a5b X-Git-Newrev: d0bc5b725dac852764b98b9b3e0560c003bd000a X-SW-Source: 2019-q4/txt/msg00532.txt.bz2 https://sourceware.org/git/gitweb.cgi?p=glibc.git;h=d0bc5b725dac852764b98b9b3e0560c003bd000a commit d0bc5b725dac852764b98b9b3e0560c003bd000a Author: Gabriel F. T. Gomes Date: Tue Dec 3 22:40:38 2019 -0300 Do not use ld.so to open statically linked programs in debugglibc.sh Debugging programs that have been dynamically linked against an uninstalled glibc requires unusual steps, such as letting gdb know where the thread db library is located and explicitly calling the loader. However, when the program under test is statically linked, these steps are not required (as a matter of fact, using the dynamic loader to run a statically linked program is wrong and will fail), and gdb should be called the usual way. This patch modifies debugglibc.sh so that it checks if the program under test is statically linked, then runs the debugger appropriately. Reviewed-by: Carlos O'Donell Diff: --- Makefile | 16 ++++++++++++++-- 1 file changed, 14 insertions(+), 2 deletions(-) diff --git a/Makefile b/Makefile index 924fdb6..b43226c 100644 --- a/Makefile +++ b/Makefile @@ -209,6 +209,7 @@ BUILD_DIR="$(common-objpfx)" CMD_FILE="$(common-objpfx)debugglibc.gdb" CONTAINER=false DIRECT=true +STATIC=false SYMBOLSFILE=true unset TESTCASE unset BREAKPOINTS @@ -297,8 +298,8 @@ do shift done -# Check for required argument -if [ ! -v TESTCASE ] +# Check for required argument and if the testcase exists +if [ ! -v TESTCASE ] || [ ! -f $${TESTCASE} ] then usage exit 1 @@ -318,6 +319,14 @@ else DIRECT="" fi +# Check if the test case is static +if file $${TESTCASE} | grep "statically linked" >/dev/null +then + STATIC=true +else + STATIC=false +fi + # Expand symbols loading command if [ "$$SYMBOLSFILE" == true ] then @@ -366,6 +375,9 @@ then # automatically attach GDB to it. WAIT_FOR_DEBUGGER=1 $(common-objpfx)testrun.sh --tool=container $${TESTCASE} & gdb -x $${TESTCASE}.gdb +elif [ "$$STATIC" == true ] +then +gdb $${TESTCASE} else # Start the test case debugging in two steps: # 1. the following command invokes gdb to run the loader;