public inbox for glibc-cvs@sourceware.org help / color / mirror / Atom feed
From: Joseph Myers <jsm28@sourceware.org> To: glibc-cvs@sourceware.org Subject: [glibc] Build raise with -fasynchronous-unwind-tables. Date: Fri, 24 Jan 2020 17:24:00 -0000 [thread overview] Message-ID: <20200124172403.32289.qmail@sourceware.org> (raw) https://sourceware.org/git/gitweb.cgi?p=glibc.git;h=352bb99754ae7c83ff1b974f9c52244e974c9410 commit 352bb99754ae7c83ff1b974f9c52244e974c9410 Author: Joseph Myers <joseph@codesourcery.com> Date: Fri Jan 24 17:23:47 2020 +0000 Build raise with -fasynchronous-unwind-tables. In testing glibc for Arm and MIPS, I see: FAIL: misc/tst-sigcontext-get_pc If this test - backtracing through a call to raise - is valid, then raise needs to be built with -fasynchronous-unwind-tables (as the test itself is) to have the required unwind information for that backtracing to work. Adding that option, which this patch does, causes the test for pass for Arm. For MIPS, the test still does not pass (the backtrace has an address that is 2 bytes after the "address in signal handler", for unknown reasons), although the patch allows a longer backtrace to be produced. Diff: --- signal/Makefile | 1 + 1 file changed, 1 insertion(+) diff --git a/signal/Makefile b/signal/Makefile index 7da67de..37de438 100644 --- a/signal/Makefile +++ b/signal/Makefile @@ -52,6 +52,7 @@ tests := tst-signal tst-sigset tst-sigsimple tst-raise tst-sigset2 \ include ../Rules +CFLAGS-raise.c += -fasynchronous-unwind-tables CFLAGS-sigpause.c += -fexceptions CFLAGS-sigsuspend.c += -fexceptions -fasynchronous-unwind-tables CFLAGS-sigtimedwait.c += -fexceptions -fasynchronous-unwind-tables
reply other threads:[~2020-01-24 17:24 UTC|newest] Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20200124172403.32289.qmail@sourceware.org \ --to=jsm28@sourceware.org \ --cc=glibc-cvs@sourceware.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).