public inbox for glibc-cvs@sourceware.org
help / color / mirror / Atom feed
* [glibc/fw/bug25486] Remove weak declaration of free from <inline-hashtab.h>
@ 2020-02-08 15:40 Florian Weimer
0 siblings, 0 replies; only message in thread
From: Florian Weimer @ 2020-02-08 15:40 UTC (permalink / raw)
To: glibc-cvs
https://sourceware.org/git/gitweb.cgi?p=glibc.git;h=c1cfeffdf9edaf3ffd8259aa43de17b75737984c
commit c1cfeffdf9edaf3ffd8259aa43de17b75737984c
Author: Florian Weimer <fweimer@redhat.com>
Date: Sat Feb 8 16:15:09 2020 +0100
Remove weak declaration of free from <inline-hashtab.h>
elf/dl-minimal.c provides a definition of free, so the function
pointer is always non-null, even before the final relocation
of the loader.
Diff:
---
include/inline-hashtab.h | 11 +++--------
1 file changed, 3 insertions(+), 8 deletions(-)
diff --git a/include/inline-hashtab.h b/include/inline-hashtab.h
index d25bb95..3c09978 100644
--- a/include/inline-hashtab.h
+++ b/include/inline-hashtab.h
@@ -25,8 +25,6 @@
#ifndef INLINE_HASHTAB_H
# define INLINE_HASHTAB_H 1
-extern void weak_function free (void *ptr);
-
struct hashtab
{
/* Table itself. */
@@ -56,8 +54,7 @@ htab_create (void)
ht->free = free;
if (! ht->entries)
{
- if (ht->free)
- ht->free (ht);
+ free (ht);
return NULL;
}
@@ -78,8 +75,7 @@ htab_delete (struct hashtab *htab)
for (i = htab->size - 1; i >= 0; i--)
free (htab->entries[i]);
- if (htab->free)
- htab->free (htab->entries);
+ htab->free (htab->entries);
free (htab);
}
@@ -167,8 +163,7 @@ htab_expand (struct hashtab *htab, int (*hash_fn) (void *))
allocated early as long as there's no corresponding free(), but
this isn't so much memory as to be significant. */
- if (htab->free)
- htab->free (oentries);
+ htab->free (oentries);
/* Use the free() corresponding to the malloc() above to free this
up. */
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2020-02-08 15:40 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-02-08 15:40 [glibc/fw/bug25486] Remove weak declaration of free from <inline-hashtab.h> Florian Weimer
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).