public inbox for glibc-cvs@sourceware.org
help / color / mirror / Atom feed
* [glibc/azanella/bz12683] nptl: Do not close the pipe on tst-cancel{2,  3}
@ 2020-04-07 14:03 Adhemerval Zanella
  0 siblings, 0 replies; 3+ messages in thread
From: Adhemerval Zanella @ 2020-04-07 14:03 UTC (permalink / raw)
  To: glibc-cvs

https://sourceware.org/git/gitweb.cgi?p=glibc.git;h=1757f156edbbbb6793fca97c87db678fe00e8138

commit 1757f156edbbbb6793fca97c87db678fe00e8138
Author: Adhemerval Zanella <adhemerval.zanella@linaro.org>
Date:   Thu Aug 15 09:06:24 2019 -0300

    nptl: Do not close the pipe on tst-cancel{2,3}
    
    This can cause a SIGPIPE before SIGCANCEL is processed, which makes
    write fail and the thread return an non expected result.
    
    Checked on x86_64-linux-gnu and powerpc64le-linux-gnu.

Diff:
---
 nptl/tst-cancel2.c | 3 ---
 nptl/tst-cancel3.c | 3 ---
 2 files changed, 6 deletions(-)

diff --git a/nptl/tst-cancel2.c b/nptl/tst-cancel2.c
index 1e86711596..1732980b0f 100644
--- a/nptl/tst-cancel2.c
+++ b/nptl/tst-cancel2.c
@@ -73,9 +73,6 @@ do_test (void)
       return 1;
     }
 
-  /* This will cause the write in the child to return.  */
-  close (fd[0]);
-
   if (pthread_join (th, &r) != 0)
     {
       puts ("join failed");
diff --git a/nptl/tst-cancel3.c b/nptl/tst-cancel3.c
index 0a531dbcdb..3a0acac5e2 100644
--- a/nptl/tst-cancel3.c
+++ b/nptl/tst-cancel3.c
@@ -75,9 +75,6 @@ do_test (void)
       return 1;
     }
 
-  /* This will cause the read in the child to return.  */
-  close (fd[0]);
-
   if (pthread_join (th, &r) != 0)
     {
       puts ("join failed");


^ permalink raw reply	[flat|nested] 3+ messages in thread
* [glibc/azanella/bz12683] nptl: Do not close the pipe on tst-cancel{2,  3}
@ 2020-04-03 20:23 Adhemerval Zanella
  0 siblings, 0 replies; 3+ messages in thread
From: Adhemerval Zanella @ 2020-04-03 20:23 UTC (permalink / raw)
  To: glibc-cvs

https://sourceware.org/git/gitweb.cgi?p=glibc.git;h=4b76322d31b7e37ba64ae3f9d93eaf9c2e79b8a9

commit 4b76322d31b7e37ba64ae3f9d93eaf9c2e79b8a9
Author: Adhemerval Zanella <adhemerval.zanella@linaro.org>
Date:   Thu Aug 15 09:06:24 2019 -0300

    nptl: Do not close the pipe on tst-cancel{2,3}
    
    This can cause a SIGPIPE before SIGCANCEL is processed, which makes
    write fail and the thread return an non expected result.
    
    Checked on x86_64-linux-gnu and powerpc64le-linux-gnu.

Diff:
---
 nptl/tst-cancel2.c | 3 ---
 nptl/tst-cancel3.c | 3 ---
 2 files changed, 6 deletions(-)

diff --git a/nptl/tst-cancel2.c b/nptl/tst-cancel2.c
index 1e86711596..1732980b0f 100644
--- a/nptl/tst-cancel2.c
+++ b/nptl/tst-cancel2.c
@@ -73,9 +73,6 @@ do_test (void)
       return 1;
     }
 
-  /* This will cause the write in the child to return.  */
-  close (fd[0]);
-
   if (pthread_join (th, &r) != 0)
     {
       puts ("join failed");
diff --git a/nptl/tst-cancel3.c b/nptl/tst-cancel3.c
index 0a531dbcdb..3a0acac5e2 100644
--- a/nptl/tst-cancel3.c
+++ b/nptl/tst-cancel3.c
@@ -75,9 +75,6 @@ do_test (void)
       return 1;
     }
 
-  /* This will cause the read in the child to return.  */
-  close (fd[0]);
-
   if (pthread_join (th, &r) != 0)
     {
       puts ("join failed");


^ permalink raw reply	[flat|nested] 3+ messages in thread
* [glibc/azanella/bz12683] nptl: Do not close the pipe on tst-cancel{2, 3}
@ 2019-10-17 13:56 Adhemerval Zanella
  0 siblings, 0 replies; 3+ messages in thread
From: Adhemerval Zanella @ 2019-10-17 13:56 UTC (permalink / raw)
  To: glibc-cvs

https://sourceware.org/git/gitweb.cgi?p=glibc.git;h=5bbe6f7a7817666adc6db625a9929b375361c194

commit 5bbe6f7a7817666adc6db625a9929b375361c194
Author: Adhemerval Zanella <adhemerval.zanella@linaro.org>
Date:   Thu Aug 15 09:06:24 2019 -0300

    nptl: Do not close the pipe on tst-cancel{2,3}
    
    This can cause a SIGPIPE before SIGCANCEL is processed, which makes
    write fail and the thread return an non expected result.
    
    Checked on x86_64-linux-gnu and powerpc64le-linux-gnu.

Diff:
---
 nptl/tst-cancel2.c | 3 ---
 nptl/tst-cancel3.c | 3 ---
 2 files changed, 6 deletions(-)

diff --git a/nptl/tst-cancel2.c b/nptl/tst-cancel2.c
index b22bd49..2df2c00 100644
--- a/nptl/tst-cancel2.c
+++ b/nptl/tst-cancel2.c
@@ -73,9 +73,6 @@ do_test (void)
       return 1;
     }
 
-  /* This will cause the write in the child to return.  */
-  close (fd[0]);
-
   if (pthread_join (th, &r) != 0)
     {
       puts ("join failed");
diff --git a/nptl/tst-cancel3.c b/nptl/tst-cancel3.c
index ea595ba..1822adf 100644
--- a/nptl/tst-cancel3.c
+++ b/nptl/tst-cancel3.c
@@ -75,9 +75,6 @@ do_test (void)
       return 1;
     }
 
-  /* This will cause the read in the child to return.  */
-  close (fd[0]);
-
   if (pthread_join (th, &r) != 0)
     {
       puts ("join failed");


^ permalink raw reply	[flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-04-07 14:03 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-04-07 14:03 [glibc/azanella/bz12683] nptl: Do not close the pipe on tst-cancel{2, 3} Adhemerval Zanella
  -- strict thread matches above, loose matches on Subject: below --
2020-04-03 20:23 Adhemerval Zanella
2019-10-17 13:56 Adhemerval Zanella

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).