public inbox for glibc-cvs@sourceware.org
help / color / mirror / Atom feed
* [glibc] Revert "x86_64: Add SSE sfp-exceptions"
@ 2020-04-20 18:24 Adhemerval Zanella
0 siblings, 0 replies; only message in thread
From: Adhemerval Zanella @ 2020-04-20 18:24 UTC (permalink / raw)
To: glibc-cvs
https://sourceware.org/git/gitweb.cgi?p=glibc.git;h=f721171632d67f397e712db52b9ce36bb46fdd96
commit f721171632d67f397e712db52b9ce36bb46fdd96
Author: Adhemerval Zanella <adhemerval.zanella@linaro.org>
Date: Mon Apr 20 08:14:48 2020 -0300
Revert "x86_64: Add SSE sfp-exceptions"
The __sfp_handle_exceptions is not fully correct regarding raising
exceptions, since there is no direct way to raise only FP_EX_OVERFLOW
nor FP_EX_UNDERFLOW for SSE mode. Both libgcc and feraiseexcept rely
on x87 mode to accomplish it.
This reverts commit 460ee50de054396cc9791ff4cfdc2f5029fb923d.
Checked on x86_64.
Diff:
---
sysdeps/x86/fpu/sfp-exceptions.c | 57 ----------------------------------------
sysdeps/x86_64/fpu/Makefile | 4 +--
2 files changed, 1 insertion(+), 60 deletions(-)
diff --git a/sysdeps/x86/fpu/sfp-exceptions.c b/sysdeps/x86/fpu/sfp-exceptions.c
deleted file mode 100644
index 74ce0716e2..0000000000
--- a/sysdeps/x86/fpu/sfp-exceptions.c
+++ /dev/null
@@ -1,57 +0,0 @@
-/* x86_64 soft-fp exception handling for _Float128.
- Copyright (C) 2020 Free Software Foundation, Inc.
- This file is part of the GNU C Library.
-
- The GNU C Library is free software; you can redistribute it and/or
- modify it under the terms of the GNU Lesser General Public
- License as published by the Free Software Foundation; either
- version 2.1 of the License, or (at your option) any later version.
-
- The GNU C Library is distributed in the hope that it will be useful,
- but WITHOUT ANY WARRANTY; without even the implied warranty of
- MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
- Lesser General Public License for more details.
-
- You should have received a copy of the GNU Lesser General Public
- License along with the GNU C Library; if not, see
- <https://www.gnu.org/licenses/>. */
-
-#include <fenv.h>
-#include <float.h>
-#include <math-barriers.h>
-#include <soft-fp.h>
-
-void
-__sfp_handle_exceptions (int _fex)
-{
- if (_fex & FP_EX_INVALID)
- {
- float f = 0.0f;
- math_force_eval (f / f);
- }
- if (_fex & FP_EX_DENORM)
- {
- float f = FLT_MIN, g = 2.0f;
- math_force_eval (f / g);
- }
- if (_fex & FP_EX_DIVZERO)
- {
- float f = 1.0f, g = 0.0f;
- math_force_eval (f / g);
- }
- if (_fex & FP_EX_OVERFLOW)
- {
- float force_underflow = FLT_MAX * FLT_MAX;
- math_force_eval (force_underflow);
- }
- if (_fex & FP_EX_UNDERFLOW)
- {
- float force_overflow = FLT_MIN * FLT_MIN;
- math_force_eval (force_overflow);
- }
- if (_fex & FP_EX_INEXACT)
- {
- float f = 1.0f, g = 3.0f;
- math_force_eval (f / g);
- }
-}
diff --git a/sysdeps/x86_64/fpu/Makefile b/sysdeps/x86_64/fpu/Makefile
index a95e3f74f4..a4ff2723a8 100644
--- a/sysdeps/x86_64/fpu/Makefile
+++ b/sysdeps/x86_64/fpu/Makefile
@@ -23,10 +23,8 @@ libmvec-support += svml_d_cos2_core svml_d_cos4_core_avx \
svml_s_sincosf8_core svml_s_sincosf16_core
endif
-ifeq ($(subdir),math)
-libm-routines += sfp-exceptions
-
# Variables for libmvec tests.
+ifeq ($(subdir),math)
ifeq ($(build-mathvec),yes)
libmvec-tests += double-vlen2 double-vlen4 double-vlen4-avx2 \
float-vlen4 float-vlen8 float-vlen8-avx2
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2020-04-20 18:24 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-04-20 18:24 [glibc] Revert "x86_64: Add SSE sfp-exceptions" Adhemerval Zanella
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).