public inbox for glibc-cvs@sourceware.org
help / color / mirror / Atom feed
From: Alistair Francis <alistair23@sourceware.org>
To: glibc-cvs@sourceware.org
Subject: [glibc/alistair/rv32.next] RISC-V: Fix llrint and llround missing exceptions on RV32
Date: Sun, 26 Apr 2020 02:26:13 +0000 (GMT)	[thread overview]
Message-ID: <20200426022613.9D3CF3938C24@sourceware.org> (raw)

https://sourceware.org/git/gitweb.cgi?p=glibc.git;h=bed534fb7b45578bc0a51a47103783ec255d339d

commit bed534fb7b45578bc0a51a47103783ec255d339d
Author: Zong Li <zongbox@gmail.com>
Date:   Fri Nov 30 17:18:20 2018 +0800

    RISC-V: Fix llrint and llround missing exceptions on RV32
    
    Similar to the fix for MIPS, ARM and S/390, RV32 is missing
    correct exception on overflow from llrint and llround functions because
    cast from floating-point types to long long do not result in correct
    exceptions on overflow.

Diff:
---
 sysdeps/riscv/rv32/fix-fp-int-convert-overflow.h | 38 ++++++++++++++++++++++++
 1 file changed, 38 insertions(+)

diff --git a/sysdeps/riscv/rv32/fix-fp-int-convert-overflow.h b/sysdeps/riscv/rv32/fix-fp-int-convert-overflow.h
new file mode 100644
index 0000000000..9137ee0fd8
--- /dev/null
+++ b/sysdeps/riscv/rv32/fix-fp-int-convert-overflow.h
@@ -0,0 +1,38 @@
+/* Fix for conversion of floating point to integer overflow. RISC-V version.
+   Copyright (C) 2015-2020 Free Software Foundation, Inc.
+   This file is part of the GNU C Library.
+
+   The GNU C Library is free software; you can redistribute it and/or
+   modify it under the terms of the GNU Lesser General Public
+   License as published by the Free Software Foundation; either
+   version 2.1 of the License, or (at your option) any later version.
+
+   The GNU C Library is distributed in the hope that it will be useful,
+   but WITHOUT ANY WARRANTY; without even the implied warranty of
+   MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
+   Lesser General Public License for more details.
+
+   You should have received a copy of the GNU Lesser General Public
+   License along with the GNU C Library; if not, see
+   <http://www.gnu.org/licenses/>.  */
+
+#ifndef FIX_FP_INT_CONVERT_OVERFLOW_H
+#define FIX_FP_INT_CONVERT_OVERFLOW_H	1
+
+/* The generic libgcc2.c conversions from floating point
+   to long long may not raise the correct exceptions on overflow (and
+   may raise spurious "inexact" exceptions even in non-overflow cases,
+   see <https://gcc.gnu.org/bugzilla/show_bug.cgi?id=59412>).  */
+#define FIX_FLT_LONG_CONVERT_OVERFLOW 0
+#define FIX_FLT_LLONG_CONVERT_OVERFLOW 1
+
+#define FIX_DBL_LONG_CONVERT_OVERFLOW 0
+#define FIX_DBL_LLONG_CONVERT_OVERFLOW 1
+
+#define FIX_LDBL_LONG_CONVERT_OVERFLOW 0
+#define FIX_LDBL_LLONG_CONVERT_OVERFLOW 0
+
+#define FIX_FLT128_LONG_CONVERT_OVERFLOW 0
+#define FIX_FLT128_LLONG_CONVERT_OVERFLOW 0
+
+#endif /* fix-fp-int-convert-overflow.h */


             reply	other threads:[~2020-04-26  2:26 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-04-26  2:26 Alistair Francis [this message]
  -- strict thread matches above, loose matches on Subject: below --
2020-04-22 22:16 Alistair Francis

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200426022613.9D3CF3938C24@sourceware.org \
    --to=alistair23@sourceware.org \
    --cc=glibc-cvs@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).