public inbox for glibc-cvs@sourceware.org help / color / mirror / Atom feed
From: Florian Weimer <fw@sourceware.org> To: glibc-cvs@sourceware.org Subject: [glibc] Makeconfig: Use $(error ...) to output error message Date: Wed, 29 Apr 2020 09:25:56 +0000 (GMT) [thread overview] Message-ID: <20200429092556.CA2DA38930C3@sourceware.org> (raw) https://sourceware.org/git/gitweb.cgi?p=glibc.git;h=9207e30d3f070712df6c4175547094be112454d2 commit 9207e30d3f070712df6c4175547094be112454d2 Author: Simon Marchi <simon.marchi@efficios.com> Date: Wed Apr 29 11:24:41 2020 +0200 Makeconfig: Use $(error ...) to output error message Being not familiar with the glibc repository, I typed "make" inside some subdirectory that has a Makefile, and was met with: $ make ../Makeconfig:42: *** missing separator. Stop. At Makeconfig:42, we have: objdir must be defined by the build-directory Makefile. Change that to use $(error ...), which I guess was the original intention. The result is: $ make ../Makeconfig:42: *** objdir must be defined by the build-directory Makefile. Stop. Diff: --- Makeconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Makeconfig b/Makeconfig index ac567caddc..dfda418aac 100644 --- a/Makeconfig +++ b/Makeconfig @@ -39,7 +39,7 @@ objpfx := $(patsubst %//,%/,$(objdir)/$(subdir)/) common-objpfx = $(objdir)/ common-objdir = $(objdir) else -objdir must be defined by the build-directory Makefile. +$(error objdir must be defined by the build-directory Makefile) endif # Root of the sysdeps tree.
reply other threads:[~2020-04-29 9:25 UTC|newest] Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20200429092556.CA2DA38930C3@sourceware.org \ --to=fw@sourceware.org \ --cc=glibc-cvs@sourceware.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).