From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <fw@sourceware.org>
Received: by sourceware.org (Postfix, from userid 2178)
 id CA2DA38930C3; Wed, 29 Apr 2020 09:25:56 +0000 (GMT)
DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org CA2DA38930C3
Content-Type: text/plain; charset="us-ascii"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
From: Florian Weimer <fw@sourceware.org>
To: glibc-cvs@sourceware.org
Subject: [glibc] Makeconfig: Use $(error ...) to output error message
X-Act-Checkin: glibc
X-Git-Author: Simon Marchi <simon.marchi@efficios.com>
X-Git-Refname: refs/heads/master
X-Git-Oldrev: 2a8682ea3bf0f366a2d971ba6abdda4b2f7c3587
X-Git-Newrev: 9207e30d3f070712df6c4175547094be112454d2
Message-Id: <20200429092556.CA2DA38930C3@sourceware.org>
Date: Wed, 29 Apr 2020 09:25:56 +0000 (GMT)
X-BeenThere: glibc-cvs@sourceware.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Glibc-cvs mailing list <glibc-cvs.sourceware.org>
List-Unsubscribe: <http://sourceware.org/mailman/options/glibc-cvs>,
 <mailto:glibc-cvs-request@sourceware.org?subject=unsubscribe>
List-Archive: <https://sourceware.org/pipermail/glibc-cvs/>
List-Help: <mailto:glibc-cvs-request@sourceware.org?subject=help>
List-Subscribe: <http://sourceware.org/mailman/listinfo/glibc-cvs>,
 <mailto:glibc-cvs-request@sourceware.org?subject=subscribe>
X-List-Received-Date: Wed, 29 Apr 2020 09:25:56 -0000

https://sourceware.org/git/gitweb.cgi?p=glibc.git;h=9207e30d3f070712df6c4175547094be112454d2

commit 9207e30d3f070712df6c4175547094be112454d2
Author: Simon Marchi <simon.marchi@efficios.com>
Date:   Wed Apr 29 11:24:41 2020 +0200

    Makeconfig: Use $(error ...) to output error message
    
    Being not familiar with the glibc repository, I typed "make" inside some
    subdirectory that has a Makefile, and was met with:
    
        $ make
        ../Makeconfig:42: *** missing separator.  Stop.
    
    At Makeconfig:42, we have:
    
        objdir must be defined by the build-directory Makefile.
    
    Change that to use $(error ...), which I guess was the original
    intention.  The result is:
    
        $ make
        ../Makeconfig:42: *** objdir must be defined by the build-directory Makefile.  Stop.

Diff:
---
 Makeconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/Makeconfig b/Makeconfig
index ac567caddc..dfda418aac 100644
--- a/Makeconfig
+++ b/Makeconfig
@@ -39,7 +39,7 @@ objpfx := $(patsubst %//,%/,$(objdir)/$(subdir)/)
 common-objpfx = $(objdir)/
 common-objdir = $(objdir)
 else
-objdir must be defined by the build-directory Makefile.
+$(error objdir must be defined by the build-directory Makefile)
 endif
 
 # Root of the sysdeps tree.