From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: by sourceware.org (Postfix, from userid 1968) id AA50538930D5; Mon, 4 May 2020 20:28:59 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org AA50538930D5 Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit From: Paul E. Murphy To: glibc-cvs@sourceware.org Subject: [glibc] float128: use builtin_signbitf128 always X-Act-Checkin: glibc X-Git-Author: Paul E. Murphy X-Git-Refname: refs/heads/master X-Git-Oldrev: 06febd8c6705c816b2f32ee7aa1f4c0184b05248 X-Git-Newrev: a49e56a945972186a829ca3ad7dec7fb9c923488 Message-Id: <20200504202859.AA50538930D5@sourceware.org> Date: Mon, 4 May 2020 20:28:59 +0000 (GMT) X-BeenThere: glibc-cvs@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Glibc-cvs mailing list List-Unsubscribe: , List-Archive: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 04 May 2020 20:28:59 -0000 https://sourceware.org/git/gitweb.cgi?p=glibc.git;h=a49e56a945972186a829ca3ad7dec7fb9c923488 commit a49e56a945972186a829ca3ad7dec7fb9c923488 Author: Paul E. Murphy Date: Tue Apr 7 16:20:35 2020 -0500 float128: use builtin_signbitf128 always The minimum GCC version has been raised to 6.2 for building glibc. Therefore, follow the advice inside the implementation and remove the GCC < 6 codepath. Likewise, remove the hidden_proto as all internal usages should inline now. Diff: --- include/math.h | 1 - sysdeps/ieee754/float128/s_signbitf128.c | 19 +------------------ 2 files changed, 1 insertion(+), 19 deletions(-) diff --git a/include/math.h b/include/math.h index 3979c47400..e1c2a4eb64 100644 --- a/include/math.h +++ b/include/math.h @@ -29,7 +29,6 @@ hidden_proto (__isnanl) hidden_proto (__finitef128) hidden_proto (__isinff128) hidden_proto (__isnanf128) -hidden_proto (__signbitf128) # endif # endif diff --git a/sysdeps/ieee754/float128/s_signbitf128.c b/sysdeps/ieee754/float128/s_signbitf128.c index 1fc00658f8..c2a1097db6 100644 --- a/sysdeps/ieee754/float128/s_signbitf128.c +++ b/sysdeps/ieee754/float128/s_signbitf128.c @@ -17,21 +17,4 @@ . */ #include -#include -#include - -/* Once GCC >= 6.0 is required for building glibc, this implementation can - be removed and replaced with an inclusion of ldbl-128/s_signbitl.c. */ -int -__signbitf128 (_Float128 x) -{ -#if __GNUC_PREREQ (6, 0) - return __builtin_signbit (x); -#else - int64_t e; - - GET_FLOAT128_MSW64 (e, x); - return e < 0; -#endif -} -hidden_def (__signbitf128) +#include "../ldbl-128/s_signbitl.c"