public inbox for glibc-cvs@sourceware.org help / color / mirror / Atom feed
From: Adhemerval Zanella <azanella@sourceware.org> To: glibc-cvs@sourceware.org Subject: [glibc] linux: Remove assembly umount2 implementation Date: Fri, 8 May 2020 20:20:16 +0000 (GMT) [thread overview] Message-ID: <20200508202016.B288F386F47A@sourceware.org> (raw) https://sourceware.org/git/gitweb.cgi?p=glibc.git;h=e1b871e25f3add3b63d465694b6731d95cafb299 commit e1b871e25f3add3b63d465694b6731d95cafb299 Author: Adhemerval Zanella <adhemerval.zanella@linaro.org> Date: Fri May 8 09:30:18 2020 -0300 linux: Remove assembly umount2 implementation Only alpha and ia64 do not support __NR_umount2 (defined as __NR_umount), but recent kernel fixes (74cd2184833f for ia64, and 12b57c5c70f39 for alpha) add the required alias. Checked with a build against all affected ABIs. Reviewed-by: Florian Weimer <fweimer@redhat.com> Diff: --- sysdeps/unix/sysv/linux/ia64/syscalls.list | 2 -- sysdeps/unix/sysv/linux/include/sys/mount.h | 31 +++++++++++++++++++++++++++++ sysdeps/unix/sysv/linux/umount.c | 8 +++----- sysdeps/unix/sysv/linux/umount2.S | 13 ------------ sysdeps/unix/sysv/linux/umount2.c | 29 +++++++++++++++++++++++++++ 5 files changed, 63 insertions(+), 20 deletions(-) diff --git a/sysdeps/unix/sysv/linux/ia64/syscalls.list b/sysdeps/unix/sysv/linux/ia64/syscalls.list index 56f4138c43..bd39441d3c 100644 --- a/sysdeps/unix/sysv/linux/ia64/syscalls.list +++ b/sysdeps/unix/sysv/linux/ia64/syscalls.list @@ -1,7 +1,5 @@ # File name Caller Syscall name # args Strong name Weak names -umount2 - umount 2 __umount2 umount2 - getpriority - getpriority i:ii __getpriority getpriority # proper socket implementations: diff --git a/sysdeps/unix/sysv/linux/include/sys/mount.h b/sysdeps/unix/sysv/linux/include/sys/mount.h new file mode 100644 index 0000000000..6f6122cca3 --- /dev/null +++ b/sysdeps/unix/sysv/linux/include/sys/mount.h @@ -0,0 +1,31 @@ +/* Internal declarations for sys/mount.h. + Copyright (C) 2020 Free Software Foundation, Inc. + This file is part of the GNU C Library. + + The GNU C Library is free software; you can redistribute it and/or + modify it under the terms of the GNU Lesser General Public + License as published by the Free Software Foundation; either + version 2.1 of the License, or (at your option) any later version. + + The GNU C Library is distributed in the hope that it will be useful, + but WITHOUT ANY WARRANTY; without even the implied warranty of + MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU + Lesser General Public License for more details. + + You should have received a copy of the GNU Lesser General Public + License along with the GNU C Library; if not, see + <https://www.gnu.org/licenses/>. */ + +#ifndef _INCLUDE_SYS_MOUNT_H +#define _INCLUDE_SYS_MOUNT_H 1 + +#include_next <sys/mount.h> + +# ifndef _ISOMAC + +extern __typeof (umount) __umount __THROW; +extern __typeof (umount2) __umount2 __THROW; +libc_hidden_proto (__umount2) + +# endif /* _ISOMAC */ +#endif /* sys/sysinfo.h */ diff --git a/sysdeps/unix/sysv/linux/umount.c b/sysdeps/unix/sysv/linux/umount.c index ab6a20f596..2a75760dfa 100644 --- a/sysdeps/unix/sysv/linux/umount.c +++ b/sysdeps/unix/sysv/linux/umount.c @@ -16,12 +16,10 @@ License along with the GNU C Library. If not, see <https://www.gnu.org/licenses/>. */ -/* Since the generic Linux syscall ABI doesn't have an oldumount system call, - do what the kernel does down here. */ +#include <sys/mount.h> +#include <sysdep.h> -extern long int __umount2 (const char *name, int flags); - -long int +int __umount (const char *name) { return __umount2 (name, 0); diff --git a/sysdeps/unix/sysv/linux/umount2.S b/sysdeps/unix/sysv/linux/umount2.S deleted file mode 100644 index 92241bbf97..0000000000 --- a/sysdeps/unix/sysv/linux/umount2.S +++ /dev/null @@ -1,13 +0,0 @@ -/* umount system call with two parameters. */ - -#include <sysdep.h> -#if defined __NR_oldumount || defined __NR_umount2 -#ifdef __NR_oldumount -PSEUDO (__umount2, umount, 2) -#else -PSEUDO (__umount2, umount2, 2) -#endif - ret -PSEUDO_END(__umount2) -weak_alias (__umount2, umount2) -#endif diff --git a/sysdeps/unix/sysv/linux/umount2.c b/sysdeps/unix/sysv/linux/umount2.c new file mode 100644 index 0000000000..a91fd50733 --- /dev/null +++ b/sysdeps/unix/sysv/linux/umount2.c @@ -0,0 +1,29 @@ +/* Unmount filesystem. + Copyright (C) 2020 Free Software Foundation, Inc. + This file is part of the GNU C Library. + + The GNU C Library is free software; you can redistribute it and/or + modify it under the terms of the GNU Lesser General Public + License as published by the Free Software Foundation; either + version 2.1 of the License, or (at your option) any later version. + + The GNU C Library is distributed in the hope that it will be useful, + but WITHOUT ANY WARRANTY; without even the implied warranty of + MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU + Lesser General Public License for more details. + + You should have received a copy of the GNU Lesser General Public + License along with the GNU C Library. If not, see + <https://www.gnu.org/licenses/>. */ + +#include <sys/mount.h> +#include <sysdep.h> + +int +__umount2 (const char *special_file, int flags) +{ + return INLINE_SYSCALL_CALL (umount2, special_file, flags); +} +libc_hidden_def (__umount2) + +weak_alias (__umount2, umount2)
reply other threads:[~2020-05-08 20:20 UTC|newest] Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20200508202016.B288F386F47A@sourceware.org \ --to=azanella@sourceware.org \ --cc=glibc-cvs@sourceware.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).