From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: by sourceware.org (Postfix, from userid 1791) id B288F386F47A; Fri, 8 May 2020 20:20:16 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org B288F386F47A Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit From: Adhemerval Zanella To: glibc-cvs@sourceware.org Subject: [glibc] linux: Remove assembly umount2 implementation X-Act-Checkin: glibc X-Git-Author: Adhemerval Zanella X-Git-Refname: refs/heads/master X-Git-Oldrev: 9f6bd1f6057e57cce9b07844c28f15859ab15d49 X-Git-Newrev: e1b871e25f3add3b63d465694b6731d95cafb299 Message-Id: <20200508202016.B288F386F47A@sourceware.org> Date: Fri, 8 May 2020 20:20:16 +0000 (GMT) X-BeenThere: glibc-cvs@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Glibc-cvs mailing list List-Unsubscribe: , List-Archive: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 08 May 2020 20:20:16 -0000 https://sourceware.org/git/gitweb.cgi?p=glibc.git;h=e1b871e25f3add3b63d465694b6731d95cafb299 commit e1b871e25f3add3b63d465694b6731d95cafb299 Author: Adhemerval Zanella Date: Fri May 8 09:30:18 2020 -0300 linux: Remove assembly umount2 implementation Only alpha and ia64 do not support __NR_umount2 (defined as __NR_umount), but recent kernel fixes (74cd2184833f for ia64, and 12b57c5c70f39 for alpha) add the required alias. Checked with a build against all affected ABIs. Reviewed-by: Florian Weimer Diff: --- sysdeps/unix/sysv/linux/ia64/syscalls.list | 2 -- sysdeps/unix/sysv/linux/include/sys/mount.h | 31 +++++++++++++++++++++++++++++ sysdeps/unix/sysv/linux/umount.c | 8 +++----- sysdeps/unix/sysv/linux/umount2.S | 13 ------------ sysdeps/unix/sysv/linux/umount2.c | 29 +++++++++++++++++++++++++++ 5 files changed, 63 insertions(+), 20 deletions(-) diff --git a/sysdeps/unix/sysv/linux/ia64/syscalls.list b/sysdeps/unix/sysv/linux/ia64/syscalls.list index 56f4138c43..bd39441d3c 100644 --- a/sysdeps/unix/sysv/linux/ia64/syscalls.list +++ b/sysdeps/unix/sysv/linux/ia64/syscalls.list @@ -1,7 +1,5 @@ # File name Caller Syscall name # args Strong name Weak names -umount2 - umount 2 __umount2 umount2 - getpriority - getpriority i:ii __getpriority getpriority # proper socket implementations: diff --git a/sysdeps/unix/sysv/linux/include/sys/mount.h b/sysdeps/unix/sysv/linux/include/sys/mount.h new file mode 100644 index 0000000000..6f6122cca3 --- /dev/null +++ b/sysdeps/unix/sysv/linux/include/sys/mount.h @@ -0,0 +1,31 @@ +/* Internal declarations for sys/mount.h. + Copyright (C) 2020 Free Software Foundation, Inc. + This file is part of the GNU C Library. + + The GNU C Library is free software; you can redistribute it and/or + modify it under the terms of the GNU Lesser General Public + License as published by the Free Software Foundation; either + version 2.1 of the License, or (at your option) any later version. + + The GNU C Library is distributed in the hope that it will be useful, + but WITHOUT ANY WARRANTY; without even the implied warranty of + MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU + Lesser General Public License for more details. + + You should have received a copy of the GNU Lesser General Public + License along with the GNU C Library; if not, see + . */ + +#ifndef _INCLUDE_SYS_MOUNT_H +#define _INCLUDE_SYS_MOUNT_H 1 + +#include_next + +# ifndef _ISOMAC + +extern __typeof (umount) __umount __THROW; +extern __typeof (umount2) __umount2 __THROW; +libc_hidden_proto (__umount2) + +# endif /* _ISOMAC */ +#endif /* sys/sysinfo.h */ diff --git a/sysdeps/unix/sysv/linux/umount.c b/sysdeps/unix/sysv/linux/umount.c index ab6a20f596..2a75760dfa 100644 --- a/sysdeps/unix/sysv/linux/umount.c +++ b/sysdeps/unix/sysv/linux/umount.c @@ -16,12 +16,10 @@ License along with the GNU C Library. If not, see . */ -/* Since the generic Linux syscall ABI doesn't have an oldumount system call, - do what the kernel does down here. */ +#include +#include -extern long int __umount2 (const char *name, int flags); - -long int +int __umount (const char *name) { return __umount2 (name, 0); diff --git a/sysdeps/unix/sysv/linux/umount2.S b/sysdeps/unix/sysv/linux/umount2.S deleted file mode 100644 index 92241bbf97..0000000000 --- a/sysdeps/unix/sysv/linux/umount2.S +++ /dev/null @@ -1,13 +0,0 @@ -/* umount system call with two parameters. */ - -#include -#if defined __NR_oldumount || defined __NR_umount2 -#ifdef __NR_oldumount -PSEUDO (__umount2, umount, 2) -#else -PSEUDO (__umount2, umount2, 2) -#endif - ret -PSEUDO_END(__umount2) -weak_alias (__umount2, umount2) -#endif diff --git a/sysdeps/unix/sysv/linux/umount2.c b/sysdeps/unix/sysv/linux/umount2.c new file mode 100644 index 0000000000..a91fd50733 --- /dev/null +++ b/sysdeps/unix/sysv/linux/umount2.c @@ -0,0 +1,29 @@ +/* Unmount filesystem. + Copyright (C) 2020 Free Software Foundation, Inc. + This file is part of the GNU C Library. + + The GNU C Library is free software; you can redistribute it and/or + modify it under the terms of the GNU Lesser General Public + License as published by the Free Software Foundation; either + version 2.1 of the License, or (at your option) any later version. + + The GNU C Library is distributed in the hope that it will be useful, + but WITHOUT ANY WARRANTY; without even the implied warranty of + MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU + Lesser General Public License for more details. + + You should have received a copy of the GNU Lesser General Public + License along with the GNU C Library. If not, see + . */ + +#include +#include + +int +__umount2 (const char *special_file, int flags) +{ + return INLINE_SYSCALL_CALL (umount2, special_file, flags); +} +libc_hidden_def (__umount2) + +weak_alias (__umount2, umount2)