public inbox for glibc-cvs@sourceware.org
help / color / mirror / Atom feed
* [glibc] elf: Remove redundant add_to_global_resize_failure call from dl_open_args
@ 2020-05-12 17:22 Florian Weimer
  0 siblings, 0 replies; only message in thread
From: Florian Weimer @ 2020-05-12 17:22 UTC (permalink / raw)
  To: glibc-cvs

https://sourceware.org/git/gitweb.cgi?p=glibc.git;h=ad78d702757a189b1fa552d607e8aaa22252a45f

commit ad78d702757a189b1fa552d607e8aaa22252a45f
Author: Florian Weimer <fweimer@redhat.com>
Date:   Tue May 12 19:06:18 2020 +0200

    elf: Remove redundant add_to_global_resize_failure  call from dl_open_args
    
    The second call does not do anything because the data structures have
    already been resized by the call that comes before the demarcation
    point.  Fixes commit a509eb117fac1d764b15eba64993f4bdb63d7f3c
    ("Avoid late dlopen failure due to scope, TLS slotinfo updates
    [BZ #25112]").
    
    Reviewed-by: Carlos O'Donell <carlos@redhat.com>

Diff:
---
 elf/dl-open.c | 5 -----
 1 file changed, 5 deletions(-)

diff --git a/elf/dl-open.c b/elf/dl-open.c
index ddcb8b53fc..8769e47051 100644
--- a/elf/dl-open.c
+++ b/elf/dl-open.c
@@ -769,11 +769,6 @@ dl_open_worker (void *a)
   DL_STATIC_INIT (new);
 #endif
 
-  /* Perform the necessary allocations for adding new global objects
-     to the global scope below, via add_to_global_update.  */
-  if (mode & RTLD_GLOBAL)
-    add_to_global_resize (new);
-
   /* Run the initializer functions of new objects.  Temporarily
      disable the exception handler, so that lazy binding failures are
      fatal.  */


^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2020-05-12 17:22 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-05-12 17:22 [glibc] elf: Remove redundant add_to_global_resize_failure call from dl_open_args Florian Weimer

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).