public inbox for glibc-cvs@sourceware.org
help / color / mirror / Atom feed
* [glibc/vineet/upstream-work] hurd: Fix hang in _hurd_raise_signal from pthread_kill
@ 2020-06-19  2:43 Vineet Gupta
  0 siblings, 0 replies; only message in thread
From: Vineet Gupta @ 2020-06-19  2:43 UTC (permalink / raw)
  To: glibc-cvs

https://sourceware.org/git/gitweb.cgi?p=glibc.git;h=fab94894d5c5b25d24010f823515fb53822d6623

commit fab94894d5c5b25d24010f823515fb53822d6623
Author: Samuel Thibault <samuel.thibault@ens-lyon.org>
Date:   Sun Jun 7 01:55:54 2020 +0200

    hurd: Fix hang in _hurd_raise_signal from pthread_kill
    
    When ss is not NULL, it is assumed to be locked.
    
    * hurd/hurd-raise.c (_hurd_raise_signal): Unlock before returning an
    error if ss is not NULL.

Diff:
---
 hurd/hurd-raise.c | 6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)

diff --git a/hurd/hurd-raise.c b/hurd/hurd-raise.c
index af464377b6..865e498bf9 100644
--- a/hurd/hurd-raise.c
+++ b/hurd/hurd-raise.c
@@ -29,7 +29,11 @@ _hurd_raise_signal (struct hurd_sigstate *ss,
 		    int signo, const struct hurd_signal_detail *detail)
 {
   if (signo <= 0 || signo >= NSIG)
-    return EINVAL;
+    {
+      if (ss)
+	__spin_unlock (&ss->lock);
+      return EINVAL;
+    }
 
   if (ss == NULL)
     {


^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2020-06-19  2:43 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-06-19  2:43 [glibc/vineet/upstream-work] hurd: Fix hang in _hurd_raise_signal from pthread_kill Vineet Gupta

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).