public inbox for glibc-cvs@sourceware.org
help / color / mirror / Atom feed
* [glibc/nsz/pacbti-v7] Rewrite abi-note.S in C.
@ 2020-07-08 12:08 Szabolcs Nagy
  0 siblings, 0 replies; only message in thread
From: Szabolcs Nagy @ 2020-07-08 12:08 UTC (permalink / raw)
  To: glibc-cvs

https://sourceware.org/git/gitweb.cgi?p=glibc.git;h=c1210543a60c2ba95f27ee94ae648f74e27b1ad7

commit c1210543a60c2ba95f27ee94ae648f74e27b1ad7
Author: Szabolcs Nagy <szabolcs.nagy@arm.com>
Date:   Wed Apr 1 16:02:03 2020 +0100

    Rewrite abi-note.S in C.
    
    Using C code allows the compiler to add target specific object file
    markings based on CFLAGS.
    
    The arm specific abi-note.S is removed and similar object file fix
    up will be avoided on AArch64 with standard branch protection.

Diff:
---
 csu/{abi-note.S => abi-note.c} | 25 +++++++++++++++----------
 sysdeps/arm/abi-note.S         |  8 --------
 2 files changed, 15 insertions(+), 18 deletions(-)

diff --git a/csu/abi-note.S b/csu/abi-note.c
similarity index 89%
rename from csu/abi-note.S
rename to csu/abi-note.c
index 2b4b5f8824..8febf4cac0 100644
--- a/csu/abi-note.S
+++ b/csu/abi-note.c
@@ -53,6 +53,8 @@ offset	length	contents
    identify the earliest release of that OS that supports this ABI.
    See abi-tags (top level) for details. */
 
+#include <link.h>
+#include <stdint.h>
 #include <config.h>
 #include <abi-tag.h>		/* OS-specific ABI tag value */
 
@@ -60,13 +62,16 @@ offset	length	contents
    name begins with `.note' and creates a PT_NOTE program header entry
    pointing at it. */
 
-	.section ".note.ABI-tag", "a"
-	.p2align 2
-	.long 1f - 0f		/* name length */
-	.long 3f - 2f		/* data length */
-	.long  1		/* note type */
-0:	.asciz "GNU"		/* vendor name */
-1:	.p2align 2
-2:	.long __ABI_TAG_OS	/* note data: the ABI tag */
-	.long __ABI_TAG_VERSION
-3:	.p2align 2		/* pad out section */
+__attribute__ ((used, aligned (4), section (".note.ABI-tag")))
+static const struct
+{
+  ElfW(Nhdr) nhdr;
+  char name[4];
+  int32_t desc[4];
+} __abi_tag = {
+  { .n_namesz = sizeof __abi_tag.name,
+    .n_descsz = sizeof __abi_tag.desc,
+    .n_type = 1 },
+  "GNU",
+  { __ABI_TAG_OS, __ABI_TAG_VERSION }
+};
diff --git a/sysdeps/arm/abi-note.S b/sysdeps/arm/abi-note.S
deleted file mode 100644
index 07bd4c4619..0000000000
--- a/sysdeps/arm/abi-note.S
+++ /dev/null
@@ -1,8 +0,0 @@
-/* Tag_ABI_align8_preserved: This code preserves 8-byte
-   alignment in any callee.  */
-	.eabi_attribute 25, 1
-/* Tag_ABI_align8_needed: This code may require 8-byte alignment from
-   the caller.  */
-	.eabi_attribute 24, 1
-
-#include <csu/abi-note.S>


^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2020-07-08 12:08 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-07-08 12:08 [glibc/nsz/pacbti-v7] Rewrite abi-note.S in C Szabolcs Nagy

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).